Support .mdx files

[bencmbrook]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Problem

vscode-remark only recognizes markdown files

vscode-remark/src/extension.js

Line 17 in a6b066c

documentSelector: [{scheme: 'file', language: 'markdown'}],

but there is now a dedicated MDX language in VS Code. it would be awesome if we could use remark lint on our MDX files!

Solution

Update the documentSelector to include MDX files

Alternatives

You can force VS Code to treat MDX as Markdown, which allows vscode-remark to work, but it comes at the cost of all the other language features of MDX in VS Code via vscode-mdx

  "files.associations": {
    "*.mdx": "markdown",
  },

[JounQin]

MDX and markdown are definitely different, and there is already vscode-mdx.

[github-actions]

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

[github-actions]

Hi! Thanks for reaching out! Because we treat issues as our backlog, we close issues that are questions since they don’t represent a task to be completed.

See our support docs for how and where to ask questions.

Thanks,
— bb

[remcohaszing]

vscode-mdx provides MDX language support. I would also like to see unified-engine based remark support for MDX.

Related issues:

• Implement overrides similar to ESLint unifiedjs/unified-engine#56
• Provide a CLI based on unified-args mdx-js/mdx#2378

I think those issues need to be resolved first. Then we can investigate support in remark-language-server / vscode-remark. We can implement something like probing in vscode-eslint.

[github-actions]

Hi team! I don’t know what’s up as there’s no phase label. Please add one so I know where it’s at.

Thanks,
— bb