First batch code cleanup pylint (#23)

* First batch of code cleanup

Author: remcom

.pylintrc

@@ -0,0 +1,8 @@
+[MASTER]
+disable=
+    C0114, # missing-module-docstring, ignore for now
+    C0115, # missing-module-docstring, ignore for now
+    C0116, # missing-function-docstring, ignore for now
+    C0301, # line-too-long, ignore for now
+    C0302, # too-many-lines, ignore for now
+    W0511, # fixme, ignore for now

custom_components/victron/base.py

@@ -1,7 +1,7 @@
 from collections.abc import Callable
-from homeassistant.helpers.typing import StateType
-
 from dataclasses import dataclass
+
+from homeassistant.helpers.typing import StateType
 from homeassistant.helpers.entity import EntityDescription
 
 

custom_components/victron/binary_sensor.py

@@ -4,11 +4,11 @@
 
 from typing import cast
 
-from homeassistant.core import HomeAssistant, HassJob
-
-
+import logging
 from dataclasses import dataclass
 
+from homeassistant.core import HomeAssistant, HassJob
+
 from homeassistant.helpers.update_coordinator import CoordinatorEntity
 
 from homeassistant.config_entries import ConfigEntry
@@ -25,7 +25,6 @@
 from .base import VictronBaseEntityDescription
 from .const import DOMAIN, register_info_dict, BoolReadEntityType
 
-import logging
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -45,24 +44,21 @@ async def async_setup_entry(
     descriptions = []
     # TODO cleanup
     register_set = victron_coordinator.processed_data()["register_set"]
-    for slave, registerLedger in register_set.items():
-        for name in registerLedger:
-            for register_name, registerInfo in register_info_dict[name].items():
+    for slave, register_ledger in register_set.items():
+        for name in register_ledger:
+            for register_name, register_info in register_info_dict[name].items():
                 _LOGGER.debug(
-                    "unit == "
-                    + str(slave)
-                    + " registerLedger == "
-                    + str(registerLedger)
-                    + " registerInfo "
+                    "unit == $s register_ledger == %s registerInfo",
+                    {str(slave), str(register_ledger)},
                 )
 
-                if isinstance(registerInfo.entityType, BoolReadEntityType):
+                if isinstance(register_info.entityType, BoolReadEntityType):
                     description = VictronEntityDescription(
                         key=register_name,
                         name=register_name.replace("_", " "),
                         slave=slave,
                     )
-                    _LOGGER.debug("composed description == " + str(description))
+                    _LOGGER.debug("composed description == %s", {str(description)})
                     descriptions.append(description)
 
     entities = []
@@ -127,6 +123,6 @@ def device_info(self) -> entity.DeviceInfo:
         return entity.DeviceInfo(
             identifiers={(DOMAIN, self.unique_id.split("_")[0])},
             name=self.unique_id.split("_")[1],
-            model=self.unique_id.split("_")[0],
+            model=self.unique_id.split("_", maxsplit=1)[0],
             manufacturer="victron",
         )

custom_components/victron/button.py

@@ -2,9 +2,10 @@
 
 from __future__ import annotations
 
-from homeassistant.core import HomeAssistant, HassJob
-
 from dataclasses import dataclass
+import logging
+
+from homeassistant.core import HomeAssistant, HassJob
 
 from homeassistant.helpers.update_coordinator import CoordinatorEntity
 
@@ -23,7 +24,6 @@
 from .coordinator import victronEnergyDeviceUpdateCoordinator
 from .const import DOMAIN, CONF_ADVANCED_OPTIONS, register_info_dict, ButtonWriteType
 
-import logging
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -45,11 +45,8 @@ async def async_setup_entry(
         for name in registerLedger:
             for register_name, registerInfo in register_info_dict[name].items():
                 _LOGGER.debug(
-                    "unit == "
-                    + str(slave)
-                    + " registerLedger == "
-                    + str(registerLedger)
-                    + " registerInfo "
+                    "unit == $s register_ledger == %s registerInfo",
+                    {str(slave), str(registerLedger)},
                 )
                 if not config_entry.options[CONF_ADVANCED_OPTIONS]:
                     continue
@@ -62,7 +59,7 @@ async def async_setup_entry(
                         device_class=ButtonDeviceClass.RESTART,
                         address=registerInfo.register,
                     )
-                    _LOGGER.debug("composed description == " + str(description))
+                    _LOGGER.debug("composed description == %s", {str(description)})
                     descriptions.append(description)
 
     entities = []

custom_components/victron/config_flow.py

@@ -7,7 +7,6 @@
 
 import voluptuous as vol
 
-
 from homeassistant import config_entries
 from homeassistant.core import HomeAssistant
 from homeassistant.data_entry_flow import FlowResult