Skip to content

Commit 28b01cd

Browse files
author
ci-bot
committed
remove comment
1 parent e07116f commit 28b01cd

File tree

1 file changed

+0
-23
lines changed

1 file changed

+0
-23
lines changed

libs/remix-debug/src/solidity-decoder/helpers/callTreeHelper.ts

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -250,29 +250,6 @@ export async function includeVariableDeclaration (tree: InternalCallTree, step,
250250

251251
const stackIndex = stack.length
252252

253-
/*
254-
For older solidity version 0.8.26, we have seen this sequence:
255-
PUSH (a var, at stack 2), DUP, PUSH (another var, at stack 3)
256-
Without the fix below the second PUSH will register the var at index 4.
257-
That isn't a really good way of fixing this, need to find a better solution.
258-
*/
259-
/*
260-
try {
261-
const symbolicStack = tree.symbolicStackManager.getStackAtStep(step)
262-
if (symbolicStack && symbolicStack.length && symbolicStack[symbolicStack.length - 1] &&
263-
symbolicStack && symbolicStack.length && symbolicStack[symbolicStack.length - 2]) {
264-
const testDup = symbolicStack[symbolicStack.length - 1]
265-
const testPush = symbolicStack[symbolicStack.length - 2]
266-
if (testDup.originOp && testDup.kind && testDup.kind === 'intermediate' && testDup.originOp.startsWith('DUP') &&
267-
testPush.kind && (testPush.kind === 'variable' || testPush.kind === 'return_value')) {
268-
console.warn('applying stack fix', step, symbolicStack)
269-
stackIndex = stack.length - 1
270-
}
271-
}
272-
} catch (e) {
273-
console.warn(e)
274-
}*/
275-
276253
// Bind variable to symbolic stack with appropriate lifecycle
277254
const variable = isReturnParamDeclaration ? existingReturnParam : newVar
278255
tree.symbolicStackManager.bindVariableWithLifecycle(

0 commit comments

Comments
 (0)