[changed] Query changes aren't route changes

Author: taion

modules/__tests__/transitionHooks-test.js

@@ -202,7 +202,7 @@ describe('When a router enters a branch', function () {
         history.pushState(null, '/news', { q: 1 })
         expect(newsFeedRouteEnterSpy.calls.length).toEqual(1)
         history.pushState(null, '/news', { q: 2 })
-        expect(newsFeedRouteEnterSpy.calls.length).toEqual(2)
+        expect(newsFeedRouteEnterSpy.calls.length).toEqual(1)
         done()
       })
     })

modules/computeChangedRoutes.js

@@ -11,17 +11,11 @@ function routeParamsChanged(route, prevState, nextState) {
   })
 }
 
-function routeQueryChanged(prevState, nextState) {
-  return prevState.location.search !== nextState.location.search
-}
-
 /**
  * Returns an object of { leaveRoutes, enterRoutes } determined by
  * the change from prevState to nextState. We leave routes if either
  * 1) they are not in the next state or 2) they are in the next state
- * but their params have changed (i.e. /users/123 => /users/456) or
- * 3) they are in the next state but the query has changed 
- * (i.e. /search?query=foo => /search?query=bar)
+ * but their params have changed (i.e. /users/123 => /users/456).
  *
  * leaveRoutes are ordered starting at the leaf route of the tree
  * we're leaving up to the common parent route. enterRoutes are ordered
@@ -34,9 +28,7 @@ function computeChangedRoutes(prevState, nextState) {
   let leaveRoutes, enterRoutes
   if (prevRoutes) {
     leaveRoutes = prevRoutes.filter(function (route) {
-      return nextRoutes.indexOf(route) === -1
-        || routeParamsChanged(route, prevState, nextState)
-        || routeQueryChanged(prevState, nextState)
+      return nextRoutes.indexOf(route) === -1 || routeParamsChanged(route, prevState, nextState)
     })
 
     // onLeave hooks start at the leaf route.