Do not allow children to be passed to activeRouteHandler

Author: mjackson

modules/components/Route.js

@@ -466,8 +466,10 @@ function computeHandlerProps(matches, query) {
     }
 
     childHandler = function (props, addedProps) {
-      var children = Array.prototype.slice.call(arguments, 2);
-      return route.props.handler.apply(null, [ mergeProperties(props, addedProps) ].concat(children));
+      if (arguments.length > 2 && typeof arguments[2] !== 'undefined')
+        throw new Error('Passing children to a route handler is not supported');
+
+      return route.props.handler.apply(null, mergeProperties(props, addedProps));
     }.bind(this, props);
   });
 

specs/Route.spec.js

@@ -112,6 +112,33 @@ describe('a Route with custom props', function() {
   });
 });
 
+describe('a route handler', function () {
+  it('may not receive children', function (done) {
+    var InvalidHandler = React.createClass({
+      displayName: 'InvalidHandler',
+      render: function () {
+        try {
+          var result = this.props.activeRouteHandler({}, React.DOM.div());
+          assert(false, 'activeRouteHandler rendered with children');
+          return result;
+        } catch (error) {
+          assert(error);
+        }
+
+        done();
+      }
+    });
+
+    var route = TestUtils.renderIntoDocument(
+      Route({ handler: InvalidHandler },
+        Route({ path: '/home', handler: App })
+      )
+    );
+
+    route.dispatch('/home');
+  });
+});
+
 describe('a Route', function() {
   it('requires a handler');
 });