Vite module resolution forced to be `node`. Breaks workers environments

[chrisvltn]

Reproduction

1. Clone the repository https://github.com/chrisvltn/react-router-issue-reproduction

git clone https://github.com/chrisvltn/react-router-issue-reproduction.git

2. Run pnpm install
3. Run pnpm dev
4. Open the dev environment in the browser

You'll see errors when importing node-specific libraries (http, https, etc.).

This reproduction environment uses the Cloudflare official template as base.

The fix branch shows a workaround fix - to add a custom Vite plugin that removes the node conditions in vite.config.ts.

System Info

System:
    OS: macOS 15.7.2
    CPU: (10) arm64 Apple M1 Max
    Memory: 2.11 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 25.3.0
    npm: 11.7.0
    pnpm: 10.26.0
  Browsers:
    Chrome: 143.0.7499.193
    Edge: 143.0.3650.139
    Firefox: 139.0.4
    Firefox Nightly: 131.0a1
    Safari: 18.6
    Safari Technology Preview: 26.0
  npmPackages:
    @react-router/dev: ^7.10.0 => 7.12.0 
    react-router: ^7.10.0 => 7.12.0 
    vite: ^7.1.7 => 7.3.1

Used Package Manager

pnpm

Expected Behavior

Page to load normally

Actual Behavior

Build breaks, as node versions of the dependency is used, which are incompatible with workers environment.

[chrisvltn]

I see this was introduced here: #13871

react-router/packages/react-router-dev/vite/plugin.ts

Lines 3529 to 3532 in d005142

	// There is no helpful export with the default external conditions (see
	// https://github.com/vitejs/vite/pull/20279 for more details). So, for now,
	// we are hardcording the default here.
	let defaultExternalConditions = ["node"];

It mentions "There is no helpful export with the default external conditions", but there actually are. algoliasearch specifies a node export, and uses default for all other environments (the package is expected to be used in browser and workers - default serves both).

[chrisvltn]

For now we're using a workaround of using a custom Vite plugin to remove node from the conditions

import { reactRouter } from "@react-router/dev/vite";
import { cloudflare } from "@cloudflare/vite-plugin";
import tailwindcss from "@tailwindcss/vite";
import { defineConfig, type Plugin } from "vite";
import tsconfigPaths from "vite-tsconfig-paths";

const removeNodeConditions: Plugin = {
  name: 'test',
  config(config) {
    if (config.ssr?.resolve?.conditions)
      config.ssr.resolve.conditions = config.ssr.resolve.conditions.filter(c => c !== 'node');
    if (config.ssr?.resolve?.externalConditions)
      config.ssr.resolve.externalConditions = config.ssr.resolve.externalConditions.filter(c => c !== 'node');
    if (config.environments?.ssr?.resolve?.conditions)
      config.environments.ssr.resolve.conditions = config.environments.ssr.resolve.conditions.filter(c => c !== 'node');
    if (config.environments?.ssr?.resolve?.externalConditions)
      config.environments.ssr.resolve.externalConditions = config.environments.ssr.resolve.externalConditions.filter(c => c !== 'node');
  },
};

export default defineConfig({
  plugins: [
    cloudflare({ viteEnvironment: { name: "ssr" } }),
    tailwindcss(),
    reactRouter(),
    tsconfigPaths(),
    removeNodeConditions,
  ],
});