Vite Plugin does not clean up all vite dev servers on close

[derenge]

Reproduction

https://stackblitz.com/edit/remix-run-remix-wdqegrhk?file=server.mjs

System Info

All systems

Used Package Manager

npm

Expected Behavior

Closing the Vite dev server should clean up the Remix plugin viteChildCompiler and the routesViteNodeContext

In reproduction, you can see a listener for SIGTERM that is left behind on each close of the vit dev server

Actual Behavior

Closing the Vit dev server only cleans up viteChildCompiler

Plugin clean up:
https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/plugin.ts#L1514

There is also a routesViteNodeContext created:
https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/plugin.ts#L1049

which creates its own dev server which is not closed:
https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/vite-node.ts#L20

[derenge]

I think the fix is as simple as

      async buildEnd() {
        await viteChildCompiler?.close();
        await routesViteNodeContext.devServer.close();
      },

[github-actions]

🤖 Hello there,

We just published version 2.16.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 2.16.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!