fix: ensure console.log()s during startup are displayed
#4235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a51f57a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625281192/npm-package-wrangler-4235You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6625281192/npm-package-wrangler-4235Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625281192/npm-package-wrangler-4235 dev path/to/script.jsAdditional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6625281192/npm-package-cloudflare-pages-shared-4235Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
1 task
Codecov Report
@@ Coverage Diff @@
## main #4235 +/- ##
==========================================
- Coverage 75.41% 75.36% -0.05%
==========================================
Files 223 223
Lines 12231 12259 +28
Branches 3161 3171 +10
==========================================
+ Hits 9224 9239 +15
- Misses 3007 3020 +13
|
RamIdeas
approved these changes
Oct 20, 2023
As of #4072, whenever Wrangler connected to the V8 inspector, it would clear V8's internal buffer of log messages. This ensured only messages logged while the inspector was connected would be displayed. Unfortunately, we only connect to the inspector once the Worker has reported it's ready to receive connections. This meant any `console.log()`s during Worker startup wouldn't be displayed. This change switches to clearing V8's buffer whenever we _disconnect_ from the inspector instead, ensuring startup logs are shown.
mrbbot
force-pushed
the
bcoll/discard-logs-on-close
branch
from
9fd7ed3 to
a51f57a
Compare
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes remix-run/remix#7616
What this PR solves / how to test:
As of #4072, whenever Wrangler connected to the V8 inspector, it would clear V8's internal buffer of log messages. This ensured only messages logged while the inspector was connected would be displayed. Unfortunately, we only connect to the inspector once the Worker has reported it's ready to receive connections. This meant any
console.log()s during Worker startup wouldn't be displayed.This change switches to clearing V8's buffer whenever we disconnect from the inspector instead, ensuring startup logs are shown. In particular, this should fix Remix's HMR, which relies on startup logs to know when the Worker is ready.
Associated docs issue(s)/PR(s):
N/A
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.