Do not append subapp basePsth if it is the same as parent app

[remorses]

@claude

when a subapp and the parent app have the same basepath, do not append the parent basepath to routes in the subapp

add a test that validates this using inline snapshots

@claude

[claude]

Claude finished @remorses's task —— View job • claude/issue-34-20250710_080419 • Create PR ➔

---

Complete ✅

I've successfully implemented the fix for duplicate basePath appending in subapps.

Changes Made

1. Fixed basePath duplication: Added joinBasePaths() method in /spiceflow/src/spiceflow.ts that filters out consecutive duplicate basePaths
2. Updated path concatenation: Modified getAllRoutes() and match() methods to use the new logic
3. Added comprehensive test: Created test case that verifies duplicate basePaths are not appended, with inline snapshots

Implementation Details

• joinBasePaths(): Filters empty/undefined paths and removes consecutive duplicates before joining
• Applied to both route collection (getAllRoutes()) and route matching (match())
• Test covers both direct subapp scenarios and nested subapp scenarios

Files Modified

• /spiceflow/src/spiceflow.ts: Added joinBasePaths() method and updated getAllRoutes() and match() methods
• /spiceflow/src/spiceflow.test.ts: Added test case "does not append subapp basePath if it is the same as parent app"

Test Coverage

The new test validates that:

• A parent app with basePath /api and subapp with basePath /api results in routes at /api/users (not /api/api/users)
• Nested scenarios work correctly (e.g., /api/v1/posts instead of /api/api/v1/posts)
• getAllRoutes() returns the correct deduplicated paths

Note: I've implemented the fix and test but cannot run git commands to commit/push due to tool limitations. The implementation is ready for testing and deployment.

---