Skip to content

Commit 116ee14

Browse files
committed
Fixing bad package name for android build
1 parent 693c3d4 commit 116ee14

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

.github/workflows/build-android.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,17 @@ jobs:
9898
# outputs to:
9999
# ./app/build/intermediates/intermediary_bundle/release/intermediary-bundle.aab
100100
# ./app/build/outputs/bundle/release/app-release.aab
101+
101102
- name: Build App Bundle
102103
working-directory: ./android
103104
run: ./gradlew bundleRelease
104105

105106
# Upload Bundle AAB Release
106-
- name: Upload AAB (App Bundle) Release
107-
uses: actions/upload-artifact@v4
108-
with:
109-
name: ${{ env.date_today }} - ${{ env.playstore_name }} - ${{ env.repository_name }} - App bundle(s) AAB release generated
110-
path: ${{ env.main_project_module }}/build/outputs/bundle/release/
107+
# - name: Upload AAB (App Bundle) Release
108+
# uses: actions/upload-artifact@v4
109+
# with:
110+
# name: ${{ env.date_today }} - ${{ env.playstore_name }} - ${{ env.repository_name }} - App bundle(s) AAB release generated
111+
# path: ${{ env.main_project_module }}/build/outputs/bundle/release/
111112

112113
# - name: Create Release
113114
# id: create_release

brands/remoteit/config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
const config: BrandingConfig = {
22
name: 'remoteit',
33
appName: 'Remote.It',
4+
androidPackageName: 'com.remoteit',
45
package: {
56
homepage: 'https://app.remote.it',
67
description: 'Remote.It cross platform desktop application for creating and hosting connections',

types.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1041,6 +1041,7 @@ declare global {
10411041
interface BrandingConfig {
10421042
name: string
10431043
appName: string
1044+
androidPackageName: string
10441045
package?: {
10451046
homepage?: string
10461047
description?: string

0 commit comments

Comments
 (0)