Fix uninstalling bin directory on *nix systems

Author: JamieRuderman

backend/src/BinaryInstaller.ts

@@ -1,7 +1,6 @@
 import tmp from 'tmp'
+import path from 'path'
 import debug from 'debug'
-import Logger from './Logger'
-import AirBrake from './AirBrake'
 import Environment from './Environment'
 import EventBus from './EventBus'
 import Installer from './Installer'
@@ -77,7 +76,12 @@ class BinaryInstaller {
       } else {
         if (existsSync(Environment.userPath)) commands.push(`rm -rf ${Environment.userPath}`)
         if (existsSync(Environment.adminPath)) commands.push(`rm -rf ${Environment.adminPath}`)
-        if (existsSync(Environment.binPath)) commands.push(`rm -rf ${Environment.binPath}`)
+        installers.map(installer => {
+          const files = installer.dependencyNames.concat(installer.binaryName)
+          files.map(
+            file => installer.fileExists(file) && commands.push(`rm -f ${path.join(Environment.binPath, file)}`)
+          )
+        })
       }
 
       await commands.exec()

backend/src/constants.ts

@@ -25,7 +25,6 @@ export const UNIX_BINARIES = '/usr/local/bin/'
 export const UNIX_USER_SETTINGS = path.join(os.homedir(), '.remoteit')
 export const UNIX_ADMIN_SETTINGS = '/etc/remoteit'
 
-// export const WIN_BINARIES = path.join(os.homedir(), 'AppData/Local/remoteit/bin')
 export const WIN_BINARIES = path.normalize('/Program Files/remoteit/')
 export const WIN_USER_SETTINGS = path.join(os.homedir(), 'AppData/Local/remoteit')
 export const WIN_ADMIN_SETTINGS = path.normalize('/ProgramData/remoteit')