fix: common assets compile with electon compile (#999)

* fix: common assets compile with electon compile

* fix: set android build action to not automatically send changes for review

Author: JamieRuderman

.circleci/config.yml

@@ -18,9 +18,6 @@ jobs: # a collection of steps
       - run:
           name: install-npm
           command: npm install
-      - run:
-          name: build-common
-          command: npx tsc -p common/tsconfig.json
       - run:
           name: compile-electron
           command: cd electron && npm run compile

.github/workflows/build-android.yml

@@ -132,6 +132,7 @@ jobs:
           status: inProgress
           inAppUpdatePriority: 0
           userFraction: 0.2
+          changesNotSentForReview: true
           # whatsNewDirectory: distribution/whatsnew
           # mappingFile: app/build/outputs/mapping/release/mapping.txt
-          # debugSymbols: app/build/intermediates/merged_native_libs/release/out/lib/
+          # debugSymbols: app/build/intermediates/merged_native_libs/release/out/lib/

electron/package.json

@@ -16,7 +16,8 @@
     "build-frontend": "cd ../ && npm run build-frontend",
     "build-electron": "cross-env NODE_ARCH=$npm_config_arch electron-builder",
     "clean": "rimraf build/* dist/*",
-    "compile": "run-s typecheck sync-assets",
+    "compile": "run-s typecheck-common typecheck sync-assets",
+    "typecheck-common": "tsc -p ../common/tsconfig.json",
     "typecheck": "tsc -p tsconfig.json",
     "sync-assets": "node ./scripts/sync-backend-assets.js",
     "copy-env": "cd .. && npm run copy-env",