fix: gracefully handle missing --delay argument#2273
Open
AkaHarshit wants to merge 1 commit into
Open
Conversation
Fixes an unhandled exception where running `nodemon --delay` without providing a time value causes the node process to crash with a TypeError.
✅ Deploy Preview for nodemon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
nodemon --delaywithout providing an argument, the CLI parser attempts to read the missing argument and inadvertently passesundefinedtoparseDelay(). This results in the process crashing with an unhandled exception:TypeError: Cannot read properties of undefined (reading 'match').Solution
Updated the
parseDelayfunction inlib/cli/parse.jswith a type guard to ensure thevalueis a string before evaluating.match(). If the argument is missing, the delay safely defaults to0milliseconds instead of crashing the process.Testing
test/cli/parse.test.jsto ensure thecli.parse('--delay')edge case is fully covered and behaves gracefully without throwing.npm testsuite to avoid regressions.node ./bin/nodemon.js --delayand verified that the process correctly initializes without exceptions.