perf: optimal option when gemma4 model is used

Author: renesansz

Makefile

@@ -86,3 +86,6 @@ serve: ## Web UI: make serve [OUTPUT_DIR=...] [HOST=...] [PORT=...] [ARGS="--ope
 
 run: ## Full pipeline: make run [SOURCE=...] [OUTPUT_DIR=...] [MODEL=...] [ARGS="..."]
 	$(ARGUS) run $(SOURCE) --output-dir $(OUTPUT_DIR) $(arg_model) $(arg_ollama_host) $(ARGS)
+
+test: ## Run tests: make test
+	PYTHONPATH=src python3 -m unittest tests.test_scanner -v

src/argus/captioner.py

@@ -234,13 +234,19 @@ def caption_frame(image_path: Path, *, model: str, ollama_host: str) -> dict:
         "messages": [
             {
                 "role": "user",
-                "content": FRAME_CAPTION_PROMPT,
                 "images": [encoded],
+                "content": FRAME_CAPTION_PROMPT,
             }
         ],
         "format": "json",
         "stream": False,
     }
+    if base_model_name(model) == "gemma4":
+        payload["options"] = {
+            "temperature": 1.0,
+            "top_p": 0.95,
+            "top_k": 64,
+        }
 
     try:
         response = ollama_chat(payload, ollama_host=ollama_host)
@@ -303,6 +309,12 @@ def summarize_captions(
         "format": "json",
         "stream": False,
     }
+    if base_model_name(model) == "gemma4":
+        payload["options"] = {
+            "temperature": 1.0,
+            "top_p": 0.95,
+            "top_k": 64,
+        }
 
     try:
         response = ollama_chat(payload, ollama_host=ollama_host)

tests/test_scanner.py

@@ -8,6 +8,7 @@
 from unittest.mock import MagicMock, patch
 
 from argus.captioner import (
+    caption_frame,
     caption_output_items,
     match_ollama_model,
     normalize_clip_title,
@@ -141,6 +142,32 @@ def test_summarize_captions_parses_json_response(self, ollama_chat_mock) -> None
         self.assertLessEqual(len(result["title"]), 100)
         self.assertEqual(result["summary"], "Wide exterior drone footage.")
         self.assertEqual(result["suggested_tags"], ["drone", "aerial"])
+        payload = ollama_chat_mock.call_args[0][0]
+        self.assertNotIn("options", payload)
+
+    @patch("argus.captioner.ollama_chat")
+    def test_summarize_captions_includes_options_for_gemma4(self, ollama_chat_mock) -> None:
+        ollama_chat_mock.return_value = {
+            "message": {
+                "content": (
+                    '{"title":"Short title","summary":"Wide exterior drone footage here.",'
+                    '"suggested_tags":["a","b","c"]}'
+                )
+            }
+        }
+
+        result = summarize_captions(
+            [{"timestamp_seconds": 1.0, "caption": "Drone shot over a road."}],
+            model="gemma4",
+            ollama_host="http://localhost:11434",
+        )
+
+        self.assertEqual(result["status"], "ok")
+        payload = ollama_chat_mock.call_args[0][0]
+        self.assertIn("options", payload)
+        self.assertEqual(payload["options"]["temperature"], 1.0)
+        self.assertEqual(payload["options"]["top_p"], 0.95)
+        self.assertEqual(payload["options"]["top_k"], 64)
 
     @patch("argus.captioner.ollama_chat")
     def test_summarize_captions_rejects_missing_title(self, ollama_chat_mock) -> None:
@@ -158,6 +185,65 @@ def test_summarize_captions_rejects_missing_title(self, ollama_chat_mock) -> Non
 
         self.assertEqual(result["status"], "error")
         self.assertIn("required fields", result["reason"])
+        payload = ollama_chat_mock.call_args[0][0]
+        self.assertNotIn("options", payload)
+
+    @patch("argus.captioner.ollama_chat")
+    def test_caption_frame_includes_options_for_gemma4(self, ollama_chat_mock) -> None:
+        ollama_chat_mock.return_value = {
+            "message": {
+                "content": json.dumps(
+                    {
+                        "short_caption": "A test frame.",
+                        "tags": ["tag"] * 40,
+                        "visible_text": [],
+                    }
+                )
+            }
+        }
+
+        with tempfile.TemporaryDirectory() as temp_dir:
+            image_path = Path(temp_dir) / "frame.jpg"
+            image_path.write_bytes(b"\xff\xd8\xff")
+            result = caption_frame(
+                image_path,
+                model="gemma4:latest",
+                ollama_host="http://localhost:11434",
+            )
+
+        self.assertEqual(result["status"], "ok")
+        payload = ollama_chat_mock.call_args[0][0]
+        self.assertIn("options", payload)
+        self.assertEqual(payload["options"]["temperature"], 1.0)
+        self.assertEqual(payload["options"]["top_p"], 0.95)
+        self.assertEqual(payload["options"]["top_k"], 64)
+
+    @patch("argus.captioner.ollama_chat")
+    def test_caption_frame_omits_options_for_non_gemma4(self, ollama_chat_mock) -> None:
+        ollama_chat_mock.return_value = {
+            "message": {
+                "content": json.dumps(
+                    {
+                        "short_caption": "A test frame.",
+                        "tags": ["tag"] * 40,
+                        "visible_text": [],
+                    }
+                )
+            }
+        }
+
+        with tempfile.TemporaryDirectory() as temp_dir:
+            image_path = Path(temp_dir) / "frame.jpg"
+            image_path.write_bytes(b"\xff\xd8\xff")
+            result = caption_frame(
+                image_path,
+                model="gemma3",
+                ollama_host="http://localhost:11434",
+            )
+
+        self.assertEqual(result["status"], "ok")
+        payload = ollama_chat_mock.call_args[0][0]
+        self.assertNotIn("options", payload)
 
     def test_normalize_clip_title_truncates_to_max_length(self) -> None:
         long_title = "word " * 40