reviewersSampleSize is not working on team reviewers

[piro0919]

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

If you're self-hosting Renovate, select which platform you are using.

None

If you're self-hosting Renovate, tell us what version of the platform you run.

No response

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

I set team to reviewers, and I set reviewersSampleSize value greater than 1.
But the correct number of people was not set for Reviewers of PR.

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "reviewers": ["team:frontend"],
  "reviewersSampleSize": 3,
  "extends": ["config:base"],
  "timezone": "Asia/Tokyo",
  "packageRules": [
    {
      "automerge": true,
      "groupName": "minorDependencies",
      "matchUpdateTypes": ["minor", "patch", "pin", "digest"]
    }
  ],
  "platformAutomerge": true,
  "schedule": ["every weekend"]
}

Relevant debug logs

No response

Have you created a minimal reproduction repository?

No reproduction repository

[viceice]

Renovate doesn't resolve teams, this is done by github:

renovate/lib/modules/platform/github/index.ts

Lines 1215 to 1232 in 84df0c0

	logger.debug(`Adding reviewers '${reviewers.join(', ')}' to #${prNo}`);
	const userReviewers = reviewers.filter((e) => !e.startsWith('team:'));
	const teamReviewers = reviewers
	.filter((e) => e.startsWith('team:'))
	.map((e) => e.replace(regEx(/^team:/), ''));
	try {
	await githubApi.postJson(
	`repos/${
	config.parentRepo ?? config.repository
	}/pulls/${prNo}/requested_reviewers`,
	{
	body: {
	reviewers: userReviewers,
	team_reviewers: teamReviewers,
	},
	}
	);

so it's not a bug and renovate can't do much about that

[viceice]

sorry, i think there's not much we can do. 🤷‍♂️

[rarkins]

What exactly is the problem here? GitHub has a bug, or just that GitHub's feature doesn't function as @piro0919 had hoped, or something else?

[mikaelol]

We're experiencing a similar issue in GitLab. We assign teams as reviewers with reviewersSampleSize set to 2, but all team members (around 20, split across two teams of ~10 each) are added as reviewers to the PR. So I guess the sample size will sample 2 occurrences from the list of reviewers, regardless of those being teams of many members or individual users.

Here's our config:

    "reviewers": [
      "team-1/core",
      "team-2/core"
    ],
    "reviewersSampleSize": 2,

I understand it may not be possible to fix, but sharing this in case others using GitLab encounter the same problem. Any insights or workarounds would be appreciated!

Maybe update documentation to reflect this? Like main...mikaelol:renovate:doc-sample-size

[Churro]

@mikaelol, have you tried enabling expandCodeOwnersGroups? -> see https://docs.renovatebot.com/configuration-options/#expandcodeownersgroups

[IchordeDionysos]

Would be neat to have expandCodeOwnersGroups for GitHub as well