.NET SDK used when respecting global.json should respect rollForward option

[MattM240499]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Bitbucket Server

Please tell us more about your question or problem

When using a global.json file in your repository, the SDK version used for running dotnet restore should respect the rollForward flag if it is set, and if it is, the SDK version used for restoration should be the latest available, according to the base version and the rollForward option chosen. It is not currently doing so and just using the version directly: https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/nuget/artifacts.ts#L64

Example global.json

{
  "sdk": "8.0.0",
  "rollForward": "latestMinor"
}

You would expect the SDK version chosen to be the latest (v8) SDK version, 8.0.405 (https://builds.dotnet.microsoft.com/dotnet/Sdk/8.0.405/dotnet-sdk-8.0.405-linux-x64.tar.gz)

However instead we get 8.0.0. Sadly for us, no artefact exists with this version (https://builds.dotnet.microsoft.com/dotnet/Sdk/8.0.0/dotnet-sdk-8.0.0-linux-x64.tar.gz), so it cannot install the tool properly.

The impact of this is it breaks lock file restoration for these projects, causing build failures when comparing the project file version against the lock file version.

The current workaround for now is to upgrade the version in the global.json file to the latest acceptable version.

Logs (if relevant)

No response

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[horihel]

hello friendly bot...

I'm not sure there's much of a point in a repro here - there simply is no code in renovate to handle rollForward

a workaround would be to let renovate handle global.json - it will create a PR that replaces 8.0.0 with the latest available sdk version - and the next renovate run will then work properly.

that might be a little of a nuisance for devs though, because that's going to force them to upgrade their sdks locally

[rarkins]

You are incorrect

[horihel]

then I'm sorry for that then - I'm eager to learn...

I looked at the globalJson rollForward type defined here and then just asked gitHub to search for the RollForward symbol - this turns up 4 findings: the schema, 2 fixtures and a readme.

This aligns with actual behaviour: it will ignore rollForward and will happily try (and fail) to install dotnet version 8.0.0.

If I'm mistaken and there is code that handles rollForward then I'd be happy to learn, as my typescript skills are very low tbh.

[rarkins]

I meant that you're incorrect about no reproduction repo being useful.

A reproduction repo is useful for demonstrating either:

1. Something happening which shouldn't
2. Something not happening which should

And for example, let's say that the feature is added. What would the developer test against if there's no reproduction repo?

[horihel]

oooh...

ok that's true.

[github-actions[bot]]

Hi there,

This Discussion has been flagged previously as needing a minimal reproduction, but one does not yet exist. This is a reminder that the reproduction is still needed in order to progress to next steps.

If you have provided a minimal reproduction which satisfies our definitions above, but it went unnoticed, please reply to this message to help us find it.

Thanks, the Renovate team