Simplify rebase instructions in PRs #36130
rarkins
started this conversation in
Suggest an Idea
Replies: 2 comments 1 reply
-
|
i think the generic rebase label is enough. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
I would say this can be closed considering: |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Tell us more.
We support three ways to rebase:
We today mention rebasing three possible times:
I think that we can remove "exact" instructions from the two PR comments and instead just say "you manually request a rebase/retry".
Then we are left with customizing the PR body only. I think we should mention only the preferred way per platform there.
Final question is: do we need to specify the exact
rebaseLabel, or would that be intuitive enough to most users if we just say "add the rebase label to this PR"?Once we decide on this, we can simplify the massageMarkdown() functions
Beta Was this translation helpful? Give feedback.
All reactions