Invalid configuration reported, but configuration seems correct (and worked before)

[derklaro]

How are you running Renovate?

A Mend.io-hosted app

Which platform you running Renovate on?

GitHub.com

Which version of Renovate are you using?

43.219.0

Please tell us more about your question or problem

I got this warning/error in my repository today:

Location: renovate.json
Error type: The renovate configuration file contains some invalid settings
Message: packageRules[1].matchPackageNames: Your input contains * or ** along with other patterns. Please remove them, as * or ** matches all patterns.

The relevant part of the configuration is:

      "matchPackageNames": [
        "*",
        "!gradle"
      ],

(full config: https://github.com/simrailtools/backend/blob/main/renovate.json)

To me the warning seems wrong as the second array entry is an exclusion to the "match all" rule. Maybe I configured this in an unsupported way, but the docs seem to support the idea in general. It might be that the array is now checked for the first time after #43836, but I'm not 100% sure.

Thanks for the help in advance!

Logs (if relevant)

No response

[RahulGautamSingh]

Yes, we made the validation around this a bit tigher, so redundant config will be called out more by the validation logic.

["*", "!gradle"] is the same as ["!gradle"], the * is redundant please remove it.

[derklaro]

Honestly, I don't know anymore why I added the extra wildcard. Made this config years ago an re-used it in a lot of repos (renovate basically disabled itself in all my repositories thanks to this 😂). Will update my config then, thank you for pointing this out!

[Trainmaster]

@RahulGautamSingh We experienced the same issue. Some weeks ago, renovate automatically migrated

"packagePatterns": ["*"],
"excludePackagePatterns": [
  "some-package"
]

to

"matchPackageNames": [
  "*",
  "!/some-package/"
]

And now it complains about it.

[RahulGautamSingh]

Looking at it. Thanks for reporting

[RahulGautamSingh]

@Trainmaster the migration logic is not currently intelligent enough to detect the redundancy, it just sees two old option and migrates them. It'd be good to get it to recognise this case though. PRs welcome