Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherited config should be resolved before merging #31278

Open
rarkins opened this issue Sep 9, 2024 · 7 comments · May be fixed by #31642
Open

Inherited config should be resolved before merging #31278

rarkins opened this issue Sep 9, 2024 · 7 comments · May be fixed by #31642
Assignees
@RahulGautamSingh
Labels
breaking Breaking change, requires major version bump core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Milestone
v39

Comments

@rarkins
Copy link
Collaborator

rarkins commented Sep 9, 2024

Describe the proposed change(s).

Discussion: #31182

To address this:

  • We should resolve presets in inherited config prior to merging the config in
  • We should log a debug message saying we're doing this
  • We should document this behavior clearly, including noting that it's not possible to use an ignorePresets entry to ignore a preset in the extends of inherited config
@rarkins rarkins added type:bug Bug fix of existing functionality priority-2-high Bugs impacting wide number of users or very important features core:config Related to config capabilities and presets labels Sep 9, 2024
@viceice viceice added the breaking Breaking change, requires major version bump label Sep 10, 2024
@viceice viceice added this to the v39 milestone Sep 10, 2024
@RahulGautamSingh
Copy link
Collaborator

We should document this behavior clearly, including noting that it's not possible to use an ignorePresets entry to ignore a preset in the extends of inherited config

We can still ignore the presets in inherited config if the ignorePresets is enabled from file config. Do you want to never ignore presets in inherited config?

@rarkins
Copy link
Collaborator Author

rarkins commented Sep 25, 2024

I meant it's not possible to ignore it from repo config. It's ok to ignore it from global (although I'm not sure that's likely)

@viceice
Copy link
Member

viceice commented Sep 26, 2024

so this no longer works?

https://github.com/visualon/renovate-config/blob/febda028480f14509fada8e327da6dea1d468a70/shared.json#L24

I'm using ignore presets inside my shared preset. 🤔

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Sep 26, 2024 •
edited
Loading

Unless you have these shared presetes inside inherited config, they should work.

@rarkins
Copy link
Collaborator Author

rarkins commented Sep 26, 2024

@viceice is that an inherited config? or an explicitly extended preset?

@viceice
Copy link
Member

viceice commented Sep 26, 2024

@viceice is that an inherited config? or an explicitly extended preset?

explicit extended

@rarkins
Copy link
Collaborator Author

rarkins commented Sep 26, 2024

I don't think this change would affect that

@RahulGautamSingh RahulGautamSingh linked a pull request Oct 1, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RahulGautamSingh RahulGautamSingh

Labels
breaking Breaking change, requires major version bump core:config Related to config capabilities and presets priority-2-high Bugs impacting wide number of users or very important features type:bug Bug fix of existing functionality
Projects
None yet
Milestone
v39
Development

Successfully merging a pull request may close this issue.

fix(config/inherit): resolve presets RahulGautamSingh/renovate
3 participants
@viceice @rarkins @RahulGautamSingh