Authenticate during client initialization

Automatically authenticate when creating new client instead of lazy
auth. Moved validation checks to initialization and removed session
validation middleware. This ensures authentication state is known
immediately when creating a client instance.

Author: bruno-costanzo

lib/fripa/client.rb

@@ -15,7 +15,7 @@ def initialize(username:, password:, config: nil)
       @config = config || Fripa.config
       @username = username
       @password = password
-      @session_cookie = nil
+      @session_cookie = authenticator.login!
     end
 
     def users
@@ -31,8 +31,6 @@ def authenticator
     end
 
     def call(method, args = [], options = {})
-      validate_session!
-
       response = perform_request(method, args, options)
 
       raise ConnectionError, "API call failed: #{response.status}" unless response.success?
@@ -42,12 +40,6 @@ def call(method, args = [], options = {})
 
     private
 
-    def validate_session!
-      return if session_cookie
-
-      self.session_cookie = authenticator.login!
-    end
-
     def perform_request(method, args, options)
       connection.post(API_PATH) do |request|
         request.headers["Content-Type"] = "application/json"

test/test_authenticator.rb

@@ -5,27 +5,25 @@
 class TestAuthenticator < Minitest::Test
   def setup
     Fripa.config = Fripa::Configuration.new(host: "ipa.demo1.freeipa.org")
-    @client = Fripa::Client.new(username: "admin", password: "Secret123")
+    VCR.use_cassette("authenticator/login_success") do
+      @client = Fripa::Client.new(username: "admin", password: "Secret123")
+    end
   end
 
   def test_authenticator_returns_client
     assert_equal @client, @client.authenticator.client
   end
 
   def test_login_raises_on_blank_username
-    client = Fripa::Client.new(username: "", password: "Secret123")
-
     error = assert_raises(ArgumentError) do
-      client.authenticator.login!
+      Fripa::Client.new(username: "", password: "Secret123")
     end
     assert_equal "Username cannot be blank", error.message
   end
 
   def test_login_raises_on_blank_password
-    client = Fripa::Client.new(username: "admin", password: nil)
-
     error = assert_raises(ArgumentError) do
-      client.authenticator.login!
+      Fripa::Client.new(username: "admin", password: nil)
     end
     assert_equal "Password cannot be blank", error.message
   end
@@ -40,11 +38,9 @@ def test_login_success
   end
 
   def test_login_with_invalid_credentials
-    client = Fripa::Client.new(username: "admin", password: "WrongPassword")
-
     VCR.use_cassette("authenticator/login_invalid_credentials") do
       error = assert_raises(Fripa::AuthenticationError) do
-        client.authenticator.login!
+        Fripa::Client.new(username: "admin", password: "WrongPassword")
       end
       assert_match(/Login failed/, error.message)
     end

test/test_client.rb

@@ -5,22 +5,28 @@
 class TestClient < Minitest::Test
   def setup
     Fripa.config = Fripa::Configuration.new(host: "ipa.demo1.freeipa.org")
-    @client = Fripa::Client.new(username: "admin", password: "Secret123")
+    VCR.use_cassette("authenticator/login_success") do
+      @client = Fripa::Client.new(username: "admin", password: "Secret123")
+    end
   end
 
   def test_initialize_with_credentials
-    client = Fripa::Client.new(username: "testuser", password: "testpass")
-    assert_equal "testuser", client.username
-    assert_equal "testpass", client.password
-    assert_equal Fripa.config, client.config
+    VCR.use_cassette("authenticator/login_success") do
+      client = Fripa::Client.new(username: "testuser", password: "testpass")
+      assert_equal "testuser", client.username
+      assert_equal "testpass", client.password
+      assert_equal Fripa.config, client.config
+    end
   end
 
   def test_initialize_with_custom_config
-    custom_config = Fripa::Configuration.new(host: "custom.example.com")
-    client = Fripa::Client.new(username: "admin", password: "secret", config: custom_config)
-    assert_equal custom_config, client.config
-    assert_equal "admin", client.username
-    assert_equal "secret", client.password
+    custom_config = Fripa::Configuration.new(host: "ipa.demo1.freeipa.org", verify_ssl: false)
+    VCR.use_cassette("authenticator/login_success") do
+      client = Fripa::Client.new(username: "admin", password: "secret", config: custom_config)
+      assert_equal custom_config, client.config
+      assert_equal "admin", client.username
+      assert_equal "secret", client.password
+    end
   end
 
   def test_call_authenticates_automatically_if_no_session

test/test_group_resource.rb

@@ -5,7 +5,9 @@
 class TestGroupResource < Minitest::Test
   def setup
     Fripa.config = Fripa::Configuration.new(host: "ipa.demo1.freeipa.org")
-    @client = Fripa::Client.new(username: "admin", password: "Secret123")
+    VCR.use_cassette("authenticator/login_success") do
+      @client = Fripa::Client.new(username: "admin", password: "Secret123")
+    end
   end
 
   def test_find_all_groups

test/test_user_resource.rb

@@ -5,7 +5,9 @@
 class TestUserResource < Minitest::Test
   def setup
     Fripa.config = Fripa::Configuration.new(host: "ipa.demo1.freeipa.org")
-    @client = Fripa::Client.new(username: "admin", password: "Secret123")
+    VCR.use_cassette("authenticator/login_success") do
+      @client = Fripa::Client.new(username: "admin", password: "Secret123")
+    end
   end
 
   def test_find_all_users