feat: add Client::certificate_parts() method (#72)

Author: jrconlin

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "a2"
-version = "0.7.0"
+version = "0.7.1"
 authors = [
   "Harry Bairstow <[email protected]>",
   "Julius de Bruijn <[email protected]>",
@@ -14,6 +14,7 @@ repository  = "https://github.com/walletconnect/a2.git"
 homepage    = "https://github.com/walletconnect/a2"
 documentation = "https://docs.rs/a2"
 edition = "2021"
+rust-version = "1.60"  # set the minimum rust version we can work with.
 
 [features]
 default = ["openssl"]

Cargo.toml

@@ -1,6 +1,5 @@
 use a2::{Client, DefaultNotificationBuilder, NotificationBuilder, NotificationOptions};
 use argparse::{ArgumentParser, Store, StoreOption, StoreTrue};
-use tokio;
 
 // An example client connectiong to APNs with a certificate and key
 #[tokio::main]

examples/certificate_client.rs

@@ -1,6 +1,5 @@
 use argparse::{ArgumentParser, Store, StoreOption, StoreTrue};
 use std::fs::File;
-use tokio;
 
 use a2::{Client, DefaultNotificationBuilder, Endpoint, NotificationBuilder, NotificationOptions};
 

examples/token_client.rs

@@ -80,6 +80,15 @@ impl Client {
         Ok(Self::new(connector, None, endpoint))
     }
 
+    /// Create a connection to APNs using the raw PEM-formatted certificate and
+    /// key, extracted from the provider client certificate you obtain from your
+    /// [Apple developer account](https://developer.apple.com/account/)
+    pub fn certificate_parts(cert_pem: &[u8], key_pem: &[u8], endpoint: Endpoint) -> Result<Client, Error> {
+        let connector = AlpnConnector::with_client_cert(cert_pem, key_pem)?;
+
+        Ok(Self::new(connector, None, endpoint))
+    }
+
     /// Create a connection to APNs using system certificates, signing every
     /// request with a signature using a private key, key id and team id
     /// provisioned from your [Apple developer
@@ -181,7 +190,7 @@ mod tests {
     use hyper::Method;
     use hyper_alpn::AlpnConnector;
 
-    const PRIVATE_KEY: &'static str = "-----BEGIN PRIVATE KEY-----
+    const PRIVATE_KEY: &str = "-----BEGIN PRIVATE KEY-----
 MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQg8g/n6j9roKvnUkwu
 lCEIvbDqlUhA5FOzcakkG90E8L+hRANCAATKS2ZExEybUvchRDuKBftotMwVEus3
 jDwmlD1Gg0yJt1e38djFwsxsfr5q2hv0Rj9fTEqAPr8H7mGm0wKxZ7iQ
@@ -458,4 +467,17 @@ jDwmlD1Gg0yJt1e38djFwsxsfr5q2hv0Rj9fTEqAPr8H7mGm0wKxZ7iQ
 
         assert_eq!(payload.to_json_string().unwrap(), body_str,);
     }
+
+    #[tokio::test]
+    /// Try to create a test client using the unencrypted key & cert provided.
+    /// These are test values that do not work with Apple, but mimic the sort
+    /// of values you should get from the Apple Developer Console.
+    async fn test_cert_parts() -> Result<(), Error> {
+        let key: Vec<u8> = include_str!("../test_cert/test.key").bytes().collect();
+        let cert: Vec<u8> = include_str!("../test_cert/test.crt").bytes().collect();
+
+        let c = Client::certificate_parts(&cert, &key, Endpoint::Sandbox)?;
+        assert!(c.signer.is_none());
+        Ok(())
+    }
 }

src/client.rs

@@ -1,4 +1,4 @@
-///! Error and result module
+/// Error and result module
 use crate::{response::Response, signer::SignerError};
 use std::io;
 use thiserror::Error;

src/error.rs

@@ -1,4 +1,4 @@
-///! The `aps` notification content builders
+/// The `aps` notification content builders
 mod default;
 mod options;
 mod web;

src/request/notification.rs

@@ -1,4 +1,4 @@
-///! Payload with `aps` and custom data
+/// Payload with `aps` and custom data
 use crate::error::Error;
 use crate::request::notification::{DefaultAlert, NotificationOptions, WebPushAlert};
 use erased_serde::Serialize;

src/request/payload.rs

@@ -248,7 +248,7 @@ fn get_time() -> i64 {
 mod tests {
     use super::*;
 
-    const PRIVATE_KEY: &'static str = "-----BEGIN PRIVATE KEY-----
+    const PRIVATE_KEY: &str = "-----BEGIN PRIVATE KEY-----
 MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQg8g/n6j9roKvnUkwu
 lCEIvbDqlUhA5FOzcakkG90E8L+hRANCAATKS2ZExEybUvchRDuKBftotMwVEus3
 jDwmlD1Gg0yJt1e38djFwsxsfr5q2hv0Rj9fTEqAPr8H7mGm0wKxZ7iQ

src/signer.rs

@@ -0,0 +1,11 @@
+This contains a self signed cert for test purposes. The password is
+"test".
+
+These values are not encrypted
+
+Key and Cert generation (unencrypted):
+
+```
+$ openssl req -newkey rsa:2048 -nodes \
+    -keyout test.key -x509 -days 3650 -out test.crt
+```