fix: calling remote config in appkit core (#5274)

Author: 0xmkh

.changeset/silver-llamas-watch.md

@@ -0,0 +1,29 @@
+---
+'@reown/appkit': patch
+'pay-test-exchange': patch
+'@reown/appkit-adapter-bitcoin': patch
+'@reown/appkit-adapter-ethers': patch
+'@reown/appkit-adapter-ethers5': patch
+'@reown/appkit-adapter-solana': patch
+'@reown/appkit-adapter-wagmi': patch
+'@reown/appkit-utils': patch
+'@reown/appkit-cdn': patch
+'@reown/appkit-cli': patch
+'@reown/appkit-codemod': patch
+'@reown/appkit-common': patch
+'@reown/appkit-controllers': patch
+'@reown/appkit-core': patch
+'@reown/appkit-experimental': patch
+'@reown/appkit-pay': patch
+'@reown/appkit-polyfills': patch
+'@reown/appkit-scaffold-ui': patch
+'@reown/appkit-siwe': patch
+'@reown/appkit-siwx': patch
+'@reown/appkit-testing': patch
+'@reown/appkit-ui': patch
+'@reown/appkit-universal-connector': patch
+'@reown/appkit-wallet': patch
+'@reown/appkit-wallet-button': patch
+---
+
+Fixed an issue where remote config endpoint was being called when using appkit core

packages/appkit/src/client/appkit-base-client.ts

@@ -182,7 +182,9 @@ export abstract class AppKitBaseClient {
     } else {
       await this.unSyncExistingConnection()
     }
-    this.remoteFeatures = await ConfigUtil.fetchRemoteFeatures(options)
+    if (!options.basic && !options.manualWCControl) {
+      this.remoteFeatures = await ConfigUtil.fetchRemoteFeatures(options)
+    }
     await ApiController.fetchUsage()
     OptionsController.setRemoteFeatures(this.remoteFeatures)
     if (this.remoteFeatures.onramp) {

packages/appkit/tests/client/appkit-base-client.test.ts

@@ -11,13 +11,15 @@ import {
   ConnectionController,
   CoreHelperUtil,
   ModalController,
+  type RemoteFeatures,
   SendController,
   WcHelpersUtil
 } from '@reown/appkit-controllers'
 import { mockChainControllerState } from '@reown/appkit-controllers/testing'
 import { ErrorUtil, TokenUtil } from '@reown/appkit-utils'
 
 import { AppKitBaseClient } from '../../src/client/appkit-base-client'
+import { ConfigUtil } from '../../src/utils/ConfigUtil'
 import { mainnet } from '../mocks/Networks'
 
 describe('AppKitBaseClient.checkAllowedOrigins', () => {
@@ -538,3 +540,106 @@ describe('AppKitBaseClient.getDisabledCaipNetworks', () => {
     expect(result[0]?.caipNetworkId).toBe('eip155:56')
   })
 })
+
+describe('AppKitBaseClient initialization', () => {
+  let fetchRemoteFeaturesSpy: MockInstance
+
+  beforeAll(() => {
+    Object.defineProperty(globalThis, 'document', {
+      value: {
+        getElementsByTagName: vi.fn(),
+        querySelector: vi.fn()
+      },
+      writable: true
+    })
+
+    Object.defineProperty(globalThis, 'navigator', {
+      value: {
+        clipboard: {
+          readText: vi.fn(() => Promise.resolve(''))
+        }
+      },
+      writable: true
+    })
+
+    Object.defineProperty(globalThis, 'window', {
+      value: { location: { origin: '' } },
+      writable: true
+    })
+  })
+
+  beforeEach(() => {
+    vi.clearAllMocks()
+    fetchRemoteFeaturesSpy = vi
+      .spyOn(ConfigUtil, 'fetchRemoteFeatures')
+      .mockResolvedValue({} as RemoteFeatures)
+  })
+
+  it('should not fetch remote config if using basic mode', async () => {
+    new (class extends AppKitBaseClient {
+      constructor() {
+        super({
+          projectId: 'test-project-id',
+          networks: [mainnet],
+          adapters: [],
+          sdkVersion: 'html-wagmi-1',
+          basic: true
+        })
+      }
+
+      async injectModalUi() {}
+      async syncIdentity() {}
+
+      override async syncAdapterConnections() {
+        return Promise.resolve()
+      }
+    })()
+
+    await vi.waitFor(() => expect(fetchRemoteFeaturesSpy).not.toHaveBeenCalled())
+  })
+
+  it('should not fetch remote config if using manual WC control', async () => {
+    new (class extends AppKitBaseClient {
+      constructor() {
+        super({
+          projectId: 'test-project-id',
+          networks: [mainnet],
+          adapters: [],
+          sdkVersion: 'html-wagmi-1',
+          manualWCControl: true
+        })
+      }
+
+      async injectModalUi() {}
+      async syncIdentity() {}
+
+      override async syncAdapterConnections() {
+        return Promise.resolve()
+      }
+    })()
+
+    await vi.waitFor(() => expect(fetchRemoteFeaturesSpy).not.toHaveBeenCalled())
+  })
+
+  it('should fetch remote config if not using basic or manual WC control', async () => {
+    new (class extends AppKitBaseClient {
+      constructor() {
+        super({
+          projectId: 'test-project-id',
+          networks: [mainnet],
+          adapters: [],
+          sdkVersion: 'html-wagmi-1'
+        })
+      }
+
+      async injectModalUi() {}
+      async syncIdentity() {}
+
+      override async syncAdapterConnections() {
+        return Promise.resolve()
+      }
+    })()
+
+    await vi.waitFor(() => expect(fetchRemoteFeaturesSpy).toHaveBeenCalled())
+  })
+})