Skip to content

Commit 2db114b

Browse files
areinenesozturk
andauthored
chore(analytics): write to Data Lake directly (#5125)
Co-authored-by: Enes <enesozturk.d@gmail.com>
1 parent 6ba0dac commit 2db114b

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

.github/workflows/ui_tests.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,16 @@ on:
7474
required: false
7575
PLAYWRIGHT_REPORT_AWS_SECRET_ACCESS_KEY:
7676
required: false
77+
AWS_APPKIT_DATA_LAKE_ROLE_TO_ASSUME:
78+
required: false
7779

7880
env:
7981
BRANCH_NAME: ${{ inputs.branch }}
82+
AWS_APPKIT_DATA_LAKE_ROLE_TO_ASSUME: ${{ secrets.AWS_APPKIT_DATA_LAKE_ROLE_TO_ASSUME }}
83+
84+
permissions:
85+
id-token: write
86+
contents: read
8087

8188
jobs:
8289
build_lab_and_extension:
@@ -469,13 +476,11 @@ jobs:
469476
echo "BUILD_CONTEXT=$CONTEXT" >> $GITHUB_ENV
470477
echo "Derived context: $CONTEXT"
471478
472-
# TODO: Migrate to OIDC
473479
- name: Configure AWS Credentials
474480
if: inputs.build_trigger_type != '' # Also skip if not uploading
475481
uses: aws-actions/configure-aws-credentials@v4
476482
with:
477-
aws-access-key-id: ${{ secrets.PLAYWRIGHT_REPORT_AWS_ACCESS_KEY_ID }}
478-
aws-secret-access-key: ${{ secrets.PLAYWRIGHT_REPORT_AWS_SECRET_ACCESS_KEY }}
483+
role-to-assume: ${{ env.AWS_APPKIT_DATA_LAKE_ROLE_TO_ASSUME }}
479484
aws-region: eu-central-1
480485

481486
# Required for Athena/Trino processing
@@ -487,8 +492,8 @@ jobs:
487492
- name: Upload Merged JSON Report to S3
488493
if: inputs.build_trigger_type != '' && always()
489494
run: |
490-
S3_BUCKET="reown.appkit.e2e.reports"
491-
S3_PREFIX="appkit/playwright-results"
495+
S3_BUCKET="walletconnect.data-lake.prod"
496+
S3_PREFIX="appkit-test-results"
492497
FILE_NAME="merged-test-results.jsonl"
493498
year=$(date +%Y)
494499
month=$(date +%m)

0 commit comments

Comments
 (0)