fix(siwx): preserve unrelated local storage sessions on delete - #5737
fix(siwx): preserve unrelated local storage sessions on delete#5737grandpig wants to merge 1 commit into
Conversation
Signed-off-by: grandpig <grandpig@outlook.com>
🦋 Changeset detectedLatest commit: 76019e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@grandpig is attempting to deploy a commit to the Reown Team on Vercel. A member of the Team first needs to authorize it. |
|
All contributors have signed the CTA ✍️ ✅ |
|
I have read the CTA Document and I hereby sign the CTA |
|
It seems that the CI failure is unrelated to this change |
|
@hilljessica8787-dot @svenvoskamp Hi! Since you've recently reviewed changes in the SIWX package, would you mind taking a look at this small LocalStorage bug fix when you have a chance? It includes regression coverage. Thanks! |
Description
Fix
LocalStorage.delete()in the SIWX package so that it only removes sessions matching both the requested chain ID and account address.The existing filter uses:
This unintentionally removes unrelated sessions when either the chain ID or account address matches.
For example, deleting
(eip155:1, 0xAAA)also removes:(eip155:1, 0xBBB)(eip155:137, 0xAAA)The filter now uses
||, preserving every session except those matching both identifiers.Regression coverage verifies that:
Type of change
Associated Issues
N/A — small, self-contained bug fix.
Showcase (Optional)
N/A — no UI changes.
Checklist