fix(utils): reject CR/LF in CACAO SIWE single-line fields - #345
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
EIP-4361 / CAIP-122 single-line fields (domain, statement, aud, version, nonce, iat, exp, nbf, requestId) must not embed carriage returns or newlines, or a caller can forge later message lines. Fail closed before formatting. Parity with walletconnect-monorepo#7311 / utils#280.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SIWEFromCacaoPayloadFormatter.formatMessageinterpolated CACAOdomain/statement/aud/version/nonce/iat/ optionalexp/nbf/requestIdinto the EIP-4361 (CAIP-122) message without rejecting embedded\r/\n.A crafted
domainlikeexample.com\nURI: https://evil.exampleforges additional message lines (same class as statement smuggling).Fail closed: reject CR/LF in those single-line fields before formatting. Sibling of walletconnect-monorepo#7311 and walletconnect-utils#280.
Resolves # (issue) n/a (hardening)
How Has This Been Tested?
invalidSingleLineFieldswift testnot run locally (SwiftPM yttrium binary download blocked here); CI is the gateDue Dilligence
Attacker model
Party that supplies CACAO payload fields used for sign/verify message reconstruction (malicious or compromised auth-request builder). No private key required. Gap is structured-field to SIWE-text integrity.
Made with Cursor