Fix bug with metrics

Author: anish-sahoo

.github/workflows/ci.yaml

@@ -79,6 +79,7 @@ jobs:
             mise.toml \
             playground-tests \
             'pkg/cli/playground*' \
+            pkg/cli/playground \
             pkg/cli/root.go; then
             echo "changed=false" >> "$GITHUB_OUTPUT"
           else

pkg/cli/playground/lib/state/runtime.js

@@ -55,10 +55,10 @@ export function applyMetric(metrics, name, value, mode) {
   if (metricMode === "increment") {
     const previous = Number(next[name] ?? 0);
     const delta = Number(value);
-    if (!Number.isFinite(previous) || !Number.isFinite(delta)) return metrics ?? current;
+    if (!Number.isFinite(previous) || !Number.isFinite(delta)) return metrics;
     next[name] = previous + delta;
   } else if (metricMode === "append") {
-    if (valueLength(value) > MAX_METRIC_ITEMS_TEXT) return metrics ?? current;
+    if (valueLength(value) > MAX_METRIC_ITEMS_TEXT) return metrics;
     const existing = next[name];
     const values = Array.isArray(existing)
       ? [...existing, value]

pkg/cli/playground/playground.css

@@ -464,6 +464,7 @@ input[type="file"]::file-selector-button {
   min-height: 280px;
 }
 .viewer-inspector {
+  height: 80px;
   min-height: 80px;
 }
 .viewer-response-body {

pkg/cli/playground_assets_test.go

@@ -13,16 +13,19 @@ import (
 func TestPlaygroundAssetGraphComplete(t *testing.T) {
 	imports := regexp.MustCompile(`(?:from\s*|import\s*)["']([^"']+)["']`)
 	styles := regexp.MustCompile(`@import\s+(?:url\()?\s*["']([^"']+)["']`)
+	htmlAssets := regexp.MustCompile(`(?:href|src)\s*=\s*["']([^"']+)["']`)
 	err := fs.WalkDir(playgroundUI, "playground", func(name string, entry fs.DirEntry, walkErr error) error {
 		require.NoError(t, walkErr)
-		if entry.IsDir() || (!strings.HasSuffix(name, ".js") && !strings.HasSuffix(name, ".css")) {
+		if entry.IsDir() || (!strings.HasSuffix(name, ".js") && !strings.HasSuffix(name, ".css") && !strings.HasSuffix(name, ".html")) {
 			return nil
 		}
 		contents, err := playgroundUI.ReadFile(name)
 		require.NoError(t, err)
 		patterns := []*regexp.Regexp{imports}
 		if strings.HasSuffix(name, ".css") {
 			patterns = []*regexp.Regexp{styles}
+		} else if strings.HasSuffix(name, ".html") {
+			patterns = []*regexp.Regexp{htmlAssets}
 		}
 		for _, pattern := range patterns {
 			for _, match := range pattern.FindAllSubmatch(contents, -1) {
@@ -31,8 +34,8 @@ func TestPlaygroundAssetGraphComplete(t *testing.T) {
 					continue
 				}
 				target := path.Clean(path.Join(path.Dir(name), reference))
-				if strings.HasPrefix(reference, "/") {
-					target = path.Join("playground", reference)
+				if rootReference, ok := strings.CutPrefix(reference, "/"); ok {
+					target = path.Join("playground", rootReference)
 				}
 				_, err := fs.Stat(playgroundUI, target)
 				require.NoError(t, err, "%s references missing asset %s", name, reference)

playground-tests/trace.test.js

@@ -27,6 +27,11 @@ test("applies metric modes", () => {
   assert.deepEqual(applyMetric({ count: 2 }, "count", 3, "increment"), { count: 5 });
   assert.deepEqual(applyMetric({ values: [1] }, "values", 2, "append"), { values: [1, 2] });
   assert.deepEqual(applyMetric({ old: true }, "old", null, "replace"), {});
+  assert.equal(applyMetric(undefined, "count", "invalid", "increment"), undefined);
+  assert.equal(
+    applyMetric(undefined, "values", "x".repeat(MAX_METRIC_ITEMS_TEXT + 1), "append"),
+    undefined,
+  );
 });
 
 test("bounds appended metric values", () => {