[#2447] Add support for multiple git author names (#2460)

Add support for multiple author names.

This is similar to how the parser handles
authors emails.

Author: CYX22222003

docs/ug/reportConfig.md

@@ -36,7 +36,8 @@ repos:
         authors:
           - author-git-host-id: Your username on GitHub, GitLab or Bitbucket
             author-display-name: Your display name
-            author-git-author-name: Author Name Of Your Git Configuration
+            author-git-author-name: 
+              - Author Name Of Your Git Configuration
             author-emails:
               - [email protected]
               - [email protected]

src/main/java/reposense/model/OneStopConfigRunConfiguration.java

@@ -59,7 +59,7 @@ public List<RepoConfiguration> getRepoConfigurations() throws InvalidLocationExc
                     Author author = new Author(rad.getAuthorGitHostId());
                     author.setEmails(rad.getAuthorEmails());
                     author.setDisplayName(rad.getAuthorDisplayName());
-                    author.setAuthorAliases(List.of(rad.getAuthorGitAuthorName()));
+                    author.setAuthorAliases(rad.getAuthorGitAuthorNames());
 
                     authorConfiguration.addAuthor(author);
                 }

src/main/java/reposense/model/reportconfig/ReportAuthorDetails.java

@@ -13,21 +13,21 @@ public class ReportAuthorDetails {
     private final List<String> authorEmails;
     private final String authorGitHostId;
     private final String authorDisplayName;
-    private final String authorGitAuthorName;
+    private final List<String> authorGitAuthorNames;
 
     @JsonCreator
     public ReportAuthorDetails(
             @JsonProperty("author-emails") List<String> authorEmails,
             @JsonProperty("author-git-host-id") String authorGitHostId,
             @JsonProperty("author-display-name") String authorDisplayName,
-            @JsonProperty("author-git-author-name") String authorGitAuthorName) {
+            @JsonProperty("author-git-author-name") List<String> authorGitAuthorNames) {
         if (authorGitHostId == null) {
             throw new IllegalArgumentException("Author Git Host ID cannot be empty.");
         }
         this.authorGitHostId = authorGitHostId;
         this.authorEmails = authorEmails == null ? new ArrayList<>() : authorEmails;
         this.authorDisplayName = authorDisplayName == null ? "" : authorDisplayName;
-        this.authorGitAuthorName = authorGitAuthorName == null ? "" : authorGitAuthorName;
+        this.authorGitAuthorNames = authorGitAuthorNames == null ? new ArrayList<>() : authorGitAuthorNames;
     }
 
     public List<String> getAuthorEmails() {
@@ -42,8 +42,8 @@ public String getAuthorDisplayName() {
         return authorDisplayName;
     }
 
-    public String getAuthorGitAuthorName() {
-        return authorGitAuthorName;
+    public List<String> getAuthorGitAuthorNames() {
+        return authorGitAuthorNames;
     }
 
     @Override
@@ -57,7 +57,7 @@ public boolean equals(Object obj) {
             return rad.getAuthorEmails().equals(this.getAuthorEmails())
                     && rad.getAuthorGitHostId().equals(this.getAuthorGitHostId())
                     && rad.getAuthorDisplayName().equals(this.getAuthorDisplayName())
-                    && rad.getAuthorGitAuthorName().equals(this.getAuthorGitAuthorName());
+                    && rad.getAuthorGitAuthorNames().equals(this.getAuthorGitAuthorNames());
         }
 
         return false;

src/systemtest/resources/ReportConfigSystemTest/report-config.yaml

@@ -19,7 +19,8 @@ repos:
         authors:
           - author-git-host-id: jedkohjk
             author-display-name: jedkohjk
-            author-git-author-name: jedkohjk
+            author-git-author-name:
+              - jedkohjk
             author-emails:
         ignore-authors-list:
         ignore-glob-list:

src/test/java/reposense/model/OneStopConfigRunConfigurationTest.java

@@ -26,7 +26,7 @@ public static void setUpActualRepoConfigurations() {
 
         List<String> emailList = List.of("[email protected]");
         ReportAuthorDetails author = new ReportAuthorDetails(emailList, "FH-30",
-                "Francis Hodianto", "Francis Hodianto");
+                "Francis Hodianto", List.of("Francis Hodianto"));
 
         List<ReportAuthorDetails> authorList = List.of(author);
         List<String> ignoreGlobList = List.of("**.md");

src/test/java/reposense/model/reportconfig/ReportAuthorDetailsTest.java

@@ -10,7 +10,7 @@ public class ReportAuthorDetailsTest {
             List.of("[email protected]"),
             "gitHostId",
             "Display Name",
-            "Git Author"
+            List.of("Git Author")
     );
 
     @Test
@@ -20,13 +20,13 @@ public void constructor_withValidInputs_success() {
                 emails,
                 "Git Host Id",
                 "Display Name",
-                "Git Author"
+                List.of("Git Author")
         );
 
         Assertions.assertEquals(emails, details.getAuthorEmails());
         Assertions.assertEquals("Git Host Id", details.getAuthorGitHostId());
         Assertions.assertEquals("Display Name", details.getAuthorDisplayName());
-        Assertions.assertEquals("Git Author", details.getAuthorGitAuthorName());
+        Assertions.assertEquals("Git Author", details.getAuthorGitAuthorNames().get(0));
     }
 
     @Test
@@ -36,7 +36,7 @@ public void constructor_nullGitHostId_throwsIllegalArgumentException() {
                     List.of("[email protected]"),
                     null,
                     "Display Name",
-                    "Git Author"
+                    List.of("Git Author")
             );
         });
     }
@@ -52,7 +52,7 @@ public void equals_equivalentObject_success() {
                 List.of("[email protected]"),
                 "gitHostId",
                 "Display Name",
-                "Git Author"
+                List.of("Git Author")
         );
 
         Assertions.assertEquals(details1, details2);
@@ -64,7 +64,7 @@ public void equals_differentObject_failure() {
                 List.of("[email protected]"),
                 "gitHostId",
                 "Display Name",
-                "Git Author"
+                List.of("Git Author")
         );
 
         Assertions.assertNotEquals(details1, details2);

src/test/java/reposense/model/reportconfig/ReportConfigurationTest.java

@@ -21,7 +21,7 @@ public static void setUp() {
 
         List<String> emailList = List.of("[email protected]");
         ReportAuthorDetails author = new ReportAuthorDetails(emailList, "FH-30",
-                "Francis Hodianto", "Francis Hodianto");
+                "Francis Hodianto", List.of("Francis Hodianto"));
 
         List<ReportAuthorDetails> authorList = List.of(author);
         List<String> ignoreGlobList = List.of("**.md");

src/test/java/reposense/parser/ReportConfigYamlParserTest.java

@@ -37,7 +37,7 @@ public static void setUp() {
         List<String> emailList = new ArrayList<>();
         emailList.add("[email protected]");
         ReportAuthorDetails author = new ReportAuthorDetails(emailList, "FH-30",
-                "Francis Hodianto", "Francis Hodianto");
+                "Francis Hodianto", List.of("Francis Hodianto"));
 
         List<ReportAuthorDetails> authorList = new ArrayList<>();
         authorList.add(author);

src/test/resources/ReportConfigYamlParserTest/report-config-valid.yaml

@@ -11,7 +11,8 @@ repos:
         authors:
           - author-git-host-id: FH-30
             author-display-name: Francis Hodianto
-            author-git-author-name: Francis Hodianto
+            author-git-author-name:
+              - Francis Hodianto
             author-emails:
               - [email protected]
         ignore-authors-list:

src/test/resources/RunConfigurationDeciderTest/both-configs/report-config.yaml

@@ -19,7 +19,8 @@ repos:
         authors:
           - author-git-host-id: jedkohjk
             author-display-name: jedkohjk
-            author-git-author-name: jedkohjk
+            author-git-author-name:
+              - jedkohjk
             author-emails:
         ignore-authors-list:
           - bot