Skip to content

Commit fb37f90

Browse files
authored
Merge pull request #120 from rerades/env-var-ga
Refactor CI workflow and Google Analytics component
2 parents 3ec34aa + 5a09cd2 commit fb37f90

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ jobs:
5757
E2E-Tests:
5858
name: E2E-Tests
5959
runs-on: ubuntu-latest
60+
# env:
61+
# PUBLIC_GA_MEASUREMENT_ID: ${{ vars.PUBLIC_GA_MEASUREMENT_ID }}
6062
steps:
6163
- uses: actions/checkout@v4
6264
- uses: pnpm/action-setup@v4
@@ -83,7 +85,7 @@ jobs:
8385
PORT: 4321
8486
HOST: 0.0.0.0
8587
BASE_URL: http://127.0.0.1:4321
86-
PUBLIC_GA_MEASUREMENT_ID: ${{ vars.PUBLIC_GA_MEASUREMENT_ID }}
88+
# PUBLIC_GA_MEASUREMENT_ID: ${{ vars.PUBLIC_GA_MEASUREMENT_ID }}
8789
steps:
8890
- uses: actions/checkout@v4
8991
- uses: pnpm/action-setup@v4

src/components/GoogleAnalytics.astro

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ const gaMeasurementId = import.meta.env.PUBLIC_GA_MEASUREMENT_ID;
1010
<>
1111
{/* Google Analytics 4 - Optimized non-blocking implementation */}
1212
{/* Script loads asynchronously with low priority to not compete with critical resources */}
13-
{/* @ts-expect-error - fetchpriority is valid HTML but not yet in TypeScript definitions */}
1413
<script
1514
async
1615
src={`https://www.googletagmanager.com/gtag/js?id=${gaMeasurementId}`}

0 commit comments

Comments
 (0)