Sometimes deposits are not marked as validated even when document is created

[PascalRepond]

Bug description:

In some instances (to be specified), the validation of a deposit creates a document but does not mark the corresponding deposit as validated. This can lead to a double validation and a document created twice.

Expected behavior:

When validating a deposit and creating a document, the deposit should always be marked as validated.

Example:
Document https://folia.unifr.ch/manage/records/documents/detail/324501 has been created
But the corresponding deposit is still "to be validated" : https://folia.unifr.ch/manage/deposit/324490/create

Steps to Reproduce:

Could not reproduce as it is a puncutal problem:

Verify https://github.com/rero/sonar/blob/staging/sonar/modules/deposits/rest.py#L201-L235

Context

This could be caused by an error during deposit reindexing, see SONAR-N0 (Sentry).
On validation, the system dumps all document resolved index fields. If there are more than 1000 fields, there is an ES error. The document is created, but the deposit is not validated!

Server:

• production (folia)

v1.8.2

[PascalRepond]

This seems to not be linked to the data and is difficult to reproduce. Maybe we should add a security on deposit validation.

[PascalRepond]

Some deposits have no link to documents in the data, maybe it is linked:

[
    '312965', '312988', '313007', '313010', '313095',
    '313097', '313107', '313114', '313118', '313146',
    '313149', '313199', '313200', '313258', '313259',
    '313260', '313261', '313262', '313264', '313265',
    '313266', '313267', '313268', '313269', '313270',
    '313271', '313272', '313273', '313274', '313275',
    '313276', '313277', '313278', '313279', '313280',
    '313282', '313283', '319486', '319487', '319488',
    '319489', '319490', '319491', '319492', '319493',
    '319494', '319495', '319496', '319497', '319498',
    '319499', '319500', '319501', '319502', '319503',
    '319504', '319505', '319596', '319627', '319702',
    '319817', '320093', '320114', '320387', '320389',
    '320506', '320507', '320508', '320509', '320510',
    '320511', '320512', '320513', '320514', '320515',
    '320516', '320517', '320518', '320519', '320520',
    '320521', '320522', '320523', '320524', '320525',
    '320526', '320527', '320528', '320529', '320543',
    '320697', '320931'
]

[PascalRepond]

This could be caused by an error during deposit reindexing, see SONAR-N0 (Sentry).
On validation, the system dumps all document resolved index fields. If there are more than 1000 fields, there is an ES error. The document is created, but the deposit is not validated!

We increased the fields limit in ES prod, but this dump mechanism might still be improved to be more robust on the app level.