Fix table colors in light mode (#9988)

### Related
* #9953

Author: emilk

crates/utils/re_log/src/lib.rs

@@ -71,8 +71,11 @@ const CRATES_AT_WARN_LEVEL: &[&str] = &[
 ];
 
 /// Never log anything less serious than a `INFO` from these crates.
+///
+/// These creates are quite spammy on debug, drowning out what we care about:
 const CRATES_AT_INFO_LEVEL: &[&str] = &[
-    // These are quite spammy on debug, drowning out what we care about:
+    "datafusion_optimizer",
+    "datafusion",
     "h2",
     "hyper",
     "prost_build",

crates/viewer/re_dataframe_ui/src/table_utils.rs

@@ -1,6 +1,6 @@
 use ahash::HashSet;
 use egui::{Context, Frame, Id, Margin, RichText, Stroke, Style};
-use re_ui::{Scale, UiExt as _, design_tokens_of, icons};
+use re_ui::{UiExt as _, design_tokens_of, icons};
 
 pub const CELL_MARGIN: Margin = Margin::symmetric(8, 6);
 
@@ -18,11 +18,13 @@ pub fn apply_table_style_fixes(style: &mut Style) {
     let design_tokens = design_tokens_of(theme);
 
     style.visuals.widgets.hovered.bg_stroke =
-        Stroke::new(1.0, design_tokens.color_table.gray(Scale::S300));
+        Stroke::new(1.0, design_tokens.table_interaction_hovered_bg_stroke());
     style.visuals.widgets.active.bg_stroke =
-        Stroke::new(1.0, design_tokens.color_table.gray(Scale::S350));
-    style.visuals.widgets.noninteractive.bg_stroke =
-        Stroke::new(1.0, design_tokens.color_table.gray(Scale::S200));
+        Stroke::new(1.0, design_tokens.table_interaction_active_bg_stroke());
+    style.visuals.widgets.noninteractive.bg_stroke = Stroke::new(
+        1.0,
+        design_tokens.table_interaction_noninteractive_bg_stroke(),
+    );
 }
 
 pub fn header_title(ui: &mut egui::Ui, title: impl Into<RichText>) -> egui::Response {
@@ -38,7 +40,7 @@ pub fn header_ui<R>(
 ) -> egui::InnerResponse<R> {
     let response = Frame::new()
         .inner_margin(CELL_MARGIN)
-        .fill(ui.design_tokens().color_table.gray(Scale::S150))
+        .fill(ui.design_tokens().table_header_bg_fill())
         .show(ui, |ui| {
             ui.set_width(ui.available_width());
             content(ui)
@@ -49,7 +51,7 @@ pub fn header_ui<R>(
     ui.painter().hline(
         rect.x_range(),
         rect.max.y - 1.0, // - 1.0 prevents it from being overdrawn by the following row
-        Stroke::new(1.0, ui.design_tokens().color_table.gray(Scale::S300)),
+        Stroke::new(1.0, ui.design_tokens().table_header_stroke_color()),
     );
 
     response
@@ -69,7 +71,11 @@ pub fn cell_ui<R>(
     ui.painter().hline(
         rect.x_range(),
         rect.max.y - 1.0, // - 1.0 prevents it from being overdrawn by the following row
-        Stroke::new(1.0, ui.design_tokens().color_table.gray(Scale::S200)),
+        Stroke::new(
+            1.0,
+            ui.design_tokens()
+                .table_interaction_noninteractive_bg_stroke(),
+        ),
     );
 
     response

crates/viewer/re_ui/src/design_token_colors.rs

@@ -82,7 +82,7 @@ impl DesignTokens {
         //TODO(ab): as per figma, use design tokens instead
         match self.theme {
             Theme::Dark => Color32::WHITE.gamma_multiply(0.04),
-            Theme::Light => Color32::BLACK.gamma_multiply(0.05),
+            Theme::Light => self.color(ColorToken::gray(S850)),
         }
     }
 
@@ -101,4 +101,39 @@ impl DesignTokens {
             Theme::Light => self.color(ColorToken::gray(S800)),
         }
     }
+
+    pub fn table_header_bg_fill(&self) -> Color32 {
+        match self.theme {
+            Theme::Dark => self.color(ColorToken::gray(S150)),
+            Theme::Light => self.color(ColorToken::gray(S850)),
+        }
+    }
+
+    pub fn table_header_stroke_color(&self) -> Color32 {
+        match self.theme {
+            Theme::Dark => self.color(ColorToken::gray(S300)),
+            Theme::Light => self.color(ColorToken::gray(S700)),
+        }
+    }
+
+    pub fn table_interaction_hovered_bg_stroke(&self) -> Color32 {
+        match self.theme {
+            Theme::Dark => self.color_table.gray(S300),
+            Theme::Light => self.color_table.gray(S700),
+        }
+    }
+
+    pub fn table_interaction_active_bg_stroke(&self) -> Color32 {
+        match self.theme {
+            Theme::Dark => self.color_table.gray(S350),
+            Theme::Light => self.color_table.gray(S650),
+        }
+    }
+
+    pub fn table_interaction_noninteractive_bg_stroke(&self) -> Color32 {
+        match self.theme {
+            Theme::Dark => self.color_table.gray(S200),
+            Theme::Light => self.color_table.gray(S800),
+        }
+    }
 }

crates/viewer/re_ui/src/design_tokens.rs

@@ -21,7 +21,7 @@ pub struct DesignTokens {
     /// Color table for all colors used in the UI.
     ///
     /// Loaded at startup from `design_tokens.json`.
-    pub color_table: ColorTable,
+    pub(crate) color_table: ColorTable, // Not public, because all colors should go via design_token_colors.rs
 
     // TODO(ab): get rid of these, they should be function calls like the rest.
     pub top_bar_color: Color32,

crates/viewer/re_viewer/src/navigation.rs

@@ -29,7 +29,7 @@ impl Navigation {
 
     pub fn replace(&mut self, display_mode: DisplayMode) -> Option<DisplayMode> {
         let previous = self.history.pop();
-        re_log::debug!("Replaced `{:?}` with `{:?}`", previous, display_mode);
+        re_log::trace!("Navigated from {previous:?} to {display_mode:?}");
         self.history.push(display_mode);
         previous
     }