Skip to content

Commit 8d6357a

Browse files
authored
No longer require graphics API validation layer for image comparision tests (#10023)
1 parent 84905c8 commit 8d6357a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

crates/viewer/re_renderer/src/device_caps.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,11 @@ pub fn testing_instance_descriptor() -> wgpu::InstanceDescriptor {
386386
let backends = wgpu::Backends::VULKAN | wgpu::Backends::METAL;
387387

388388
let flags = (
389-
wgpu::InstanceFlags::ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER | wgpu::InstanceFlags::VALIDATION
389+
wgpu::InstanceFlags::ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER
390+
// Validation would be great, but it looks like we don't always get validation layers, causing this error:
391+
// `InstanceFlags::VALIDATION requested, but unable to find layer: VK_LAYER_KHRONOS_validation`
392+
//| wgpu::InstanceFlags::VALIDATION
393+
390394
// TODO(andreas): GPU based validation layer sounds like a great idea,
391395
// but as of writing this makes tests crash on my Windows machine!
392396
// It looks like the crash is in the Vulkan/Nvidia driver, but further investigation is needed.

0 commit comments

Comments
 (0)