Remove redundant comments from mirror active field code

Author: rockythorn

apollo/rpmworker/rh_matcher_activities.py

@@ -790,7 +790,6 @@ async def match_rh_repos(params) -> None:
     all_advisories = {}
 
     for mirror in supported_product.rh_mirrors:
-        # Skip inactive mirrors
         if not mirror.active:
             logger.debug(f"Skipping inactive mirror {mirror.name}")
             continue

apollo/server/routes/admin_supported_products.py

@@ -273,15 +273,12 @@ async def _import_configuration(import_data: List[Dict[str, Any]], replace_exist
             continue
 
         if existing_mirror and replace_existing:
-            # Delete existing repositories
             await SupportedProductsRpmRepomd.filter(supported_products_rh_mirror=existing_mirror).delete()
             mirror = existing_mirror
-            # Update active field if provided
             mirror.active = mirror_data.get("active", True)
             await mirror.save()
             updated_count += 1
         else:
-            # Create new mirror
             mirror = SupportedProductsRhMirror(
                 supported_product=product,
                 name=mirror_data["name"],
@@ -383,12 +380,10 @@ async def admin_supported_product(request: Request, product_id: int):
     if isinstance(product, Response):
         return product
 
-    # Fetch mirrors with explicit ordering: active first, then by version (desc), then by name
     mirrors = await SupportedProductsRhMirror.filter(
         supported_product=product
     ).order_by("-active", "-match_major_version", "name").prefetch_related("rpm_repomds").all()
 
-    # Get detailed statistics for each mirror
     for mirror in mirrors:
         repomds_count = await SupportedProductsRpmRepomd.filter(
             supported_products_rh_mirror=mirror
@@ -495,12 +490,10 @@ async def admin_supported_product_mirror_new_post(
     if isinstance(product, Response):
         return product
 
-    # Parse form data to get the active field
     form_data_raw = await request.form()
     # Checkbox sends "true" when checked, nothing when unchecked
     active_value = "true" if "true" in form_data_raw.getlist("active") else "false"
 
-    # Validation using centralized validation utility
     form_data = {
         "name": name,
         "match_variant": match_variant,
@@ -598,12 +591,10 @@ async def admin_supported_product_mirror_post(
     if isinstance(mirror, Response):
         return mirror
 
-    # Parse form data to get the active field
     form_data = await request.form()
     # Checkbox sends "true" when checked, nothing when unchecked
     active_value = "true" if "true" in form_data.getlist("active") else "false"
 
-    # Validation using centralized validation utility
     try:
         validated_name = FieldValidator.validate_name(
             name,
@@ -810,7 +801,6 @@ async def admin_supported_product_mirror_repomd_new_post(
     if isinstance(mirror, Response):
         return mirror
 
-    # Validation using centralized validation utility
     form_data = {
         "production": production,
         "arch": arch,
@@ -902,7 +892,6 @@ async def admin_supported_product_mirror_repomd_post(
     if isinstance(repomd, Response):
         return repomd
 
-    # Validation using centralized validation utility
     form_data = {
         "production": production,
         "arch": arch,

apollo/tests/test_admin_routes_supported_products.py

@@ -446,31 +446,26 @@ class TestActiveFieldCheckboxParsing(unittest.TestCase):
 
     def test_checkbox_checked_returns_true(self):
         """Test that checked checkbox results in active_value='true'."""
-        # Simulate form data when checkbox is checked
         from unittest.mock import Mock
         form_data = Mock()
         form_data.getlist.return_value = ["true"]
 
-        # Apply the parsing logic from admin_supported_products.py
         active_value = "true" if "true" in form_data.getlist("active") else "false"
 
         self.assertEqual(active_value, "true")
 
     def test_checkbox_unchecked_returns_false(self):
         """Test that unchecked checkbox results in active_value='false'."""
-        # Simulate form data when checkbox is unchecked (empty list)
         from unittest.mock import Mock
         form_data = Mock()
         form_data.getlist.return_value = []
 
-        # Apply the parsing logic from admin_supported_products.py
         active_value = "true" if "true" in form_data.getlist("active") else "false"
 
         self.assertEqual(active_value, "false")
 
     def test_checkbox_missing_field_defaults_to_false(self):
         """Test that missing active field defaults to false."""
-        # Simulate form data without active field at all
         from unittest.mock import Mock
         form_data = Mock()
         form_data.getlist.return_value = []
@@ -481,7 +476,6 @@ def test_checkbox_missing_field_defaults_to_false(self):
 
     def test_checkbox_boolean_conversion(self):
         """Test that string active_value converts correctly to boolean."""
-        # Test conversion to boolean for database storage
         active_value_true = "true"
         active_value_false = "false"
 
@@ -490,14 +484,12 @@ def test_checkbox_boolean_conversion(self):
 
     def test_checkbox_with_unexpected_value(self):
         """Test that unexpected values default to false."""
-        # Edge case: unexpected value
         from unittest.mock import Mock
         form_data = Mock()
         form_data.getlist.return_value = ["yes", "1", "on"]
 
         active_value = "true" if "true" in form_data.getlist("active") else "false"
 
-        # Should default to false since "true" is not in the list
         self.assertEqual(active_value, "false")