You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For best results, initiate chat on the files or code changes.
@vorasmit Thanks — that makes sense.
The disabled = 0 uniqueness fix in c63129c addresses my concern.
And agreed on the migration point: given the #4434 invariant in india_compliance/gst_india/overrides/tax_category.py plus the set_india_compliance_default_tax_category backfill behavior, a default Tax Category with gst_state set should not exist, so that reconciliation concern doesn’t apply here.
✏️ Learnings added
Learnt from: vorasmit
URL: https://github.com/resilient-tech/india-compliance/pull/4485
Timestamp: 2026-06-26T10:55:11.431Z
Learning: In `india_compliance/gst_india/overrides/tax_category.py`, the validation introduced in PR `#4434` prevents saving a `Tax Category` document with both `is_india_compliance_default = 1` and `gst_state` set.
Learnt from: vorasmit
URL: https://github.com/resilient-tech/india-compliance/pull/4485
Timestamp: 2026-06-26T10:55:11.431Z
Learning: The `set_india_compliance_default_tax_category` backfill in the India Compliance tax-category flow only marks categories where `gst_state` is unset, and ensures at most one default per `(is_inter_state, is_reverse_charge)` combination.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
If you found this review helpful, would you consider giving us a shout-out on X?
Tip
For best results, initiate chat on the files or code changes.
@vorasmitThanks — that makes sense.The
disabled = 0uniqueness fix inc63129caddresses my concern.And agreed on the migration point: given the
#4434invariant inindia_compliance/gst_india/overrides/tax_category.pyplus theset_india_compliance_default_tax_categorybackfill behavior, a default Tax Category withgst_stateset should not exist, so that reconciliation concern doesn’t apply here.✏️ Learnings added
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
Originally posted by @coderabbitai[bot] in #4485 (comment)