enable trigger from str

Author: Tomperez98

.ruff.toml

@@ -10,6 +10,7 @@ ignore = [
     "S101",
     "ARG002",
     "ARG003",
+    "ANN401",
 ]
 logger-objects = ["resonate.logging.logger"]
 

src/resonate/context.py

@@ -33,7 +33,7 @@ def __init__(
     ) -> None:
         self._deps = deps
 
-    def get_dependency(self, key: str) -> Any:  # noqa: ANN401
+    def get_dependency(self, key: str) -> Any:
         return self._deps.get(key)
 
     def sleep(self, secs: int) -> RFC:
@@ -59,7 +59,7 @@ def rfc(
         **kwargs: P.kwargs,
     ) -> RFC: ...
     @overload
-    def rfc(self, func: str, /, *args: Any, **kwargs: Any) -> RFC: ...  # noqa: ANN401
+    def rfc(self, func: str, /, *args: Any, **kwargs: Any) -> RFC: ...
     @overload
     def rfc(
         self,
@@ -109,7 +109,7 @@ def rfi(
         **kwargs: P.kwargs,
     ) -> RFI: ...
     @overload
-    def rfi(self, func: str, /, *args: Any, **kwargs: Any) -> RFI: ...  # noqa: ANN401
+    def rfi(self, func: str, /, *args: Any, **kwargs: Any) -> RFI: ...
     @overload
     def rfi(
         self,

src/resonate/dataclasses.py

@@ -142,8 +142,8 @@ def __init__(
         self,
         fn: str,
         /,
-        *args: Any,  # noqa: ANN401
-        **kwargs: Any,  # noqa: ANN401
+        *args: Any,
+        **kwargs: Any,
     ) -> None: ...
     @overload
     def __init__(

src/resonate/dependencies.py

@@ -9,11 +9,11 @@
 class Dependencies:
     deps: dict[str, Any] = field(default_factory=dict)
 
-    def set(self, key: str, obj: Any) -> None:  # noqa: ANN401
+    def set(self, key: str, obj: Any) -> None:
         assert not self._exists(key), f"There's already a dependency under name `{key}`"
         self.deps[key] = obj
 
-    def get(self, key: str) -> Any:  # noqa: ANN401
+    def get(self, key: str) -> Any:
         return self.deps[key]
 
     def _exists(self, key: str) -> bool:

src/resonate/encoders.py

@@ -29,7 +29,7 @@ def decode(self, data: str) -> str:
         return base64.b64decode(data).decode()
 
 
-def _object_hook(data: dict[str, Any]) -> Any:  # noqa: ANN401
+def _object_hook(data: dict[str, Any]) -> Any:
     if "__type" in data:
         error_cls = _import_class_from_qualified_name(data["__type"])
         return error_cls(**data["attributes"])
@@ -39,15 +39,15 @@ def _object_hook(data: dict[str, Any]) -> Any:  # noqa: ANN401
 
 @final
 class JsonEncoder(IEncoder[Any, str]):
-    def encode(self, data: Any) -> str:  # noqa: ANN401
+    def encode(self, data: Any) -> str:
         if isinstance(data, Exception):
             data = {
                 "__type": _classname(data),
                 "attributes": data.__dict__,
             }
         return json.dumps(data)
 
-    def decode(self, data: str) -> Any:  # noqa: ANN401
+    def decode(self, data: str) -> Any:
         return json.loads(data, object_hook=_object_hook)
 
 
@@ -60,7 +60,7 @@ def _classname(obj: object) -> str:
     return name
 
 
-def _import_class_from_qualified_name(qualified_name: str) -> Any:  # noqa: ANN401
+def _import_class_from_qualified_name(qualified_name: str) -> Any:
     module_name, class_name = qualified_name.rsplit(".", 1)
     module = importlib.import_module(module_name)
     return getattr(module, class_name)

src/resonate/resonate.py

@@ -96,7 +96,7 @@ def stop(self) -> None:
         """
         self._scheduler.stop()
 
-    def set_dependency(self, key: str, obj: Any) -> None:  # noqa: ANN401
+    def set_dependency(self, key: str, obj: Any) -> None:
         """
         Sets a dependency to be used by the Application Node.
 
@@ -223,6 +223,16 @@ def run(
             func = func.fn
         return self._scheduler.run(id, func, *args, **kwargs)
 
+    @overload
+    def trigger(
+        self,
+        id: str,
+        target: str,
+        func: str,
+        /,
+        *args: Any,
+        **kwargs: Any,
+    ) -> Handle[Any]: ...
     @overload
     def trigger(
         self,
@@ -258,7 +268,8 @@ def trigger(
             Generator[Yieldable, Any, T],
         ]
         | Callable[Concatenate[Context, P], T]
-        | Callable[Concatenate[Context, P], Coroutine[Any, Any, T]],
+        | Callable[Concatenate[Context, P], Coroutine[Any, Any, T]]
+        | str,
         /,
         *args: P.args,
         **kwargs: P.kwargs,

src/resonate/scheduler/scheduler.py

@@ -134,7 +134,7 @@ def trigger(
         self,
         id: str,
         target: str,
-        func: DurableCoro[P, T] | DurableFn[P, T],
+        func: DurableCoro[P, T] | DurableFn[P, T] | str,
         /,
         *args: P.args,
         **kwargs: P.kwargs,

src/resonate/scheduler/traits.py

@@ -34,7 +34,7 @@ def trigger(
         self,
         id: str,
         target: str,
-        func: DurableCoro[P, T] | DurableFn[P, T],
+        func: DurableCoro[P, T] | DurableFn[P, T] | str,
         /,
         *args: P.args,
         **kwargs: P.kwargs,

src/resonate/utils.py

@@ -23,7 +23,7 @@ def string_to_uuid(string: str) -> str:
 
 def exit_on_exception(func: F) -> F:
     @wraps(func)
-    def wrapper(*args: Any, **kwargs: Any) -> Any:  # noqa: ANN401
+    def wrapper(*args: Any, **kwargs: Any) -> Any:
         try:
             return func(*args, **kwargs)
         except Exception:

tests/test_encoders.py

@@ -16,7 +16,7 @@ def test_base64_encoder(data: str) -> None:
 
 
 @pytest.mark.parametrize("data", [1, {"value": 3}, {"number": "1", "text": 312}])
-def test_json_encoder(data: Any) -> None:  # noqa: ANN401
+def test_json_encoder(data: Any) -> None:
     encoder = JsonEncoder()
     encoded = encoder.encode(data=data)
     assert data == encoder.decode(encoded)

tests/test_functionality.py

@@ -855,12 +855,11 @@ def bar_golden_device_rfi(ctx: Context, n: str) -> str:  # noqa: ARG001
         store=RemoteStore(url=os.environ["RESONATE_STORE_URL"]),
         task_source=Poller("http://localhost:8002", group=other_group),
     )
-    resonate.register(foo_golden_device_rfi)
     other_resonate.register(foo_golden_device_rfi)
     other_resonate.register(bar_golden_device_rfi)
 
     p: Handle[str] = resonate.trigger(
-        f"{group}-foo", poll(other_group), foo_golden_device_rfi, "hi"
+        f"{group}-foo", poll(other_group), "foo_golden_device_rfi", "hi"
     )
     assert isinstance(p, Handle)
     assert p.result() == "hi"