Merge pull request #94 from danielgtaylor/fix-20

fix: panic when multiple configured APIs have the same base URL

Author: danielgtaylor

cli/apiconfig.go

@@ -1,6 +1,7 @@
 package cli
 
 import (
+	"fmt"
 	"io/ioutil"
 	"os"
 	"path"
@@ -112,16 +113,20 @@ func initAPIConfig() {
 		panic(err)
 	}
 
+	seen := map[string]bool{}
 	for apiName, config := range configs {
 		func(config *APIConfig) {
+			if seen[config.Base] {
+				panic(fmt.Errorf("Multiple APIs configured with the same base URL: %s", config.Base))
+			}
+			seen[config.Base] = true
 			config.name = apiName
 			configs[apiName] = config
 
 			n := apiName
-			c := config
 			cmd := &cobra.Command{
 				Use:   n,
-				Short: c.Base,
+				Short: config.Base,
 				Run: func(cmd *cobra.Command, args []string) {
 					cmd.Help()
 				},

cli/cli_test.go

@@ -3,6 +3,7 @@ package cli
 import (
 	"net/http"
 	"os"
+	"path"
 	"strings"
 	"testing"
 	"time"
@@ -239,3 +240,33 @@ func TestAPISync(t *testing.T) {
 
 	runNoReset("api sync sync-test")
 }
+
+func TestDuplicateAPIBase(t *testing.T) {
+	defer func() {
+		os.Remove(path.Join(userHomeDir(), ".test", "apis.json"))
+		reset(false)
+	}()
+	reset(false)
+
+	configs["dupe1"] = &APIConfig{
+		name: "dupe1",
+		Base: "https://dupe.example.com",
+		Profiles: map[string]*APIProfile{
+			"default": {},
+		},
+	}
+	configs["dupe2"] = &APIConfig{
+		name: "dupe2",
+		Base: "https://dupe.example.com",
+		Profiles: map[string]*APIProfile{
+			"default": {},
+		},
+	}
+
+	configs["dupe1"].Save()
+	configs["dupe2"].Save()
+
+	assert.Panics(t, func() {
+		run("--help")
+	})
+}