-
-
Notifications
You must be signed in to change notification settings - Fork 394
Open
Labels
bugAny sort of bugAny sort of bugwaiting for 0.4This issue will be fixed in 0.4This issue will be fixed in 0.4
Description
The RegisterHotKey function's fsModifiers parameter is a UINT, so these constants should be UINTs as well:
Lines 1949 to 1953 in 7abd241
| pub const MOD_ALT: LPARAM = 0x0001; | |
| pub const MOD_CONTROL: LPARAM = 0x0002; | |
| pub const MOD_SHIFT: LPARAM = 0x0004; | |
| pub const MOD_WIN: LPARAM = 0x0008; | |
| pub const MOD_NOREPEAT: LPARAM = 0x4000; |
Although these same constants can be used for WM_HOTKEY message LPARAM comparisons, they are only meant to be compared to the LPARAM's low-order word, so UHALF_PTR would be optimal in that scenario, however the RegisterHotKey function should probably be given priority seeing as the constants are declared immediately after it.
Metadata
Metadata
Assignees
Labels
bugAny sort of bugAny sort of bugwaiting for 0.4This issue will be fixed in 0.4This issue will be fixed in 0.4