Conversation
Zotero 8 is based on Firefox 140 which removed several deprecated APIs. This commit updates the plugin to work with Zotero 8.0.1+. Changes: bootstrap.ts: - Remove non-existent locale registration (locale/en-US/ doesn't exist) - Remove non-existent FTL file loading (folder-import.ftl doesn't exist) content/folder-import.ts: - Replace Zotero.MenuManager and ztoolkit.Menu APIs with direct DOM manipulation - Use doc.createXULElement() to create menu item - Insert menu item after "Import from Clipboard" in File menu - More reliable across Zotero versions content/debug.ts: - Replace zotero-plugin logger with simple Zotero.debug() wrapper - Avoids deprecated ChromeUtils.import() calls esbuild.js: - Update zotero-plugin imports: 'rdf' → 'make-manifest', 'version' → 'make-version' tsconfig.json: - Add "moduleResolution": "bundler" for proper module resolution - Add "skipLibCheck": true to skip type checking of declaration files package.json: - Add patch-package for automatic patching of dependencies - Update zotero-plugin-toolkit to 5.1.0-beta.13 - Update zotero-types to 4.0.5 (stable) patches/zotero-plugin-toolkit+5.1.0-beta.13.patch: - Fix ChromeUtils.import() → ChromeUtils.importESModule() in toolkit - Patch basic.js: Console.jsm → Console.sys.mjs - Patch pluginBridge.js: AddonManager.jsm → AddonManager.sys.mjs Fixes retorquere#46, retorquere#47, retorquere#48
|
Before anything else: I appreciate the effort, and that you just want this to work. I've pushed changes to make the plugin z8 compatible and released a new version. I did some light testing and it seems to work. I am severely backlogged and am dealing with stuff in my personal life that eats up a lot of time I would usually spend on the plugins. I am however not merging this PR, and given the comment you placed with the PR, I think you somewhat expected this. Some of the reasons are:
|
|
yes, its not meant to be merged. its in case anyone is blocked by V8, and it gives you an idea of what kind of work needs to be done |
|
Alright. I understand beggars can't be choosers, but for any future PRs (even ones that are not intended to be merged), it would save me review time if it only made required changes, and not cosmetic changes like replacing zotero-plugin-toolkit for menu creation. I did not have to update anything about that to have it work for me in 0.0.10. |
|
I couldn't get it to work otherwise. js/ts and browser internals is not my forté. sigh, commenting reopens it. sorry |
2 participants
This allows ZFI to run on Zotero8. It's not meant as a permanent fix because it requires patching some underlying libraries that are also not Z8 compatible. Rather, it's meant to point the way to an official release once the dependencies are fixed.