Fix incorrect error messages when renaming users

retrixe · retrixe · commit 4163fa643432 · 2025-07-07T10:23:44.000+05:30
diff --git a/endpoints_auth.go b/endpoints_auth.go
@@ -242,7 +242,7 @@ func accountsEndpointPatch(connector *Connector, w http.ResponseWriter, r *http.
 	if username == "" { // Legacy compat with older API, assume body.Username, fix in 2.0
 		username = body.Username
 	}
-	toUpdateUsername := body.Username != username && body.Username != ""
+	toUpdateUsername := r.URL.Query().Get("username") != "" && body.Username != ""
 	if err != nil {
 		httpError(w, "Invalid JSON body!", http.StatusBadRequest)
 		return false

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ func accountsEndpointPatch(connector Connector, w http.ResponseWriter, r http.`
`242`	`242`	`if username == "" { // Legacy compat with older API, assume body.Username, fix in 2.0`
`243`	`243`	`username = body.Username`
`244`	`244`	`}`
`245`		`- toUpdateUsername := body.Username != username && body.Username != ""`
	`245`	`+ toUpdateUsername := r.URL.Query().Get("username") != "" && body.Username != ""`
`246`	`246`	`if err != nil {`
`247`	`247`	`httpError(w, "Invalid JSON body!", http.StatusBadRequest)`
`248`	`248`	`return false`