Merge pull request #18 from rewindio/hotfix/fix_extension_processing

Address issues with extension filtering

Author: mgrachev

Dockerfile

@@ -5,7 +5,7 @@ ENV REVIEWDOG_VERSION v0.10.2
 SHELL ["/bin/ash", "-eo", "pipefail", "-c"]
 
 # hadolint ignore=DL3018
-RUN apk add --update --no-cache build-base git grep
+RUN apk add --update --no-cache build-base git pcre-tools
 RUN wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s -- -b /usr/local/bin/ $REVIEWDOG_VERSION
 
 COPY entrypoint.sh /entrypoint.sh

entrypoint.sh

@@ -10,15 +10,15 @@ cd "${GITHUB_WORKSPACE}/${INPUT_WORKDIR}" || exit 1
 export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"
 
 # if 'gemfile' rubocop version selected
-if [[ $INPUT_RUBOCOP_VERSION = "gemfile" ]]; then
+if [ "${INPUT_RUBOCOP_VERSION}" = "gemfile" ]; then
   # if Gemfile.lock is here
-  if [[ -f 'Gemfile.lock' ]]; then
+  if [ -f 'Gemfile.lock' ]; then
     # grep for rubocop version
-    RUBOCOP_GEMFILE_VERSION=`cat Gemfile.lock | grep -oP '^\s{4}rubocop\s\(\K.*(?=\))'`
+    RUBOCOP_GEMFILE_VERSION=$(pcregrep -o '^\s{4}rubocop\s\(\K.*(?=\))' Gemfile.lock)
 
     # if rubocop version found, then pass it to the gem install
     # left it empty otherwise, so no version will be passed
-    if [[ -n "$RUBOCOP_GEMFILE_VERSION" ]]; then
+    if [ -n "$RUBOCOP_GEMFILE_VERSION" ]; then
       RUBOCOP_VERSION=$RUBOCOP_GEMFILE_VERSION
       else
         printf "Cannot get the rubocop's version from Gemfile.lock. The latest version will be installed."
@@ -31,24 +31,24 @@ if [[ $INPUT_RUBOCOP_VERSION = "gemfile" ]]; then
     RUBOCOP_VERSION=$INPUT_RUBOCOP_VERSION
 fi
 
-gem install -N rubocop $(version $RUBOCOP_VERSION)
+gem install -N rubocop --version "${RUBOCOP_VERSION}"
 
 # Traverse over list of rubocop extensions
 for extension in $INPUT_RUBOCOP_EXTENSIONS; do
   # grep for name and version
-  INPUT_RUBOCOP_EXTENSION_NAME=`echo $extension | grep -oP '^rubocop-\w*'`
-  INPUT_RUBOCOP_EXTENSION_VERSION=`echo $extension | grep -oP '^rubocop-\w*:\K(.*)'`
+  INPUT_RUBOCOP_EXTENSION_NAME=$(echo "$extension" |awk 'BEGIN { FS = ":" } ; { print $1 }')
+  INPUT_RUBOCOP_EXTENSION_VERSION=$(echo "$extension" |awk 'BEGIN { FS = ":" } ; { print $2 }')
 
   # if version is 'gemfile'
-  if [[ $INPUT_RUBOCOP_EXTENSION_VERSION = "gemfile" ]]; then
+  if [ "${INPUT_RUBOCOP_EXTENSION_VERSION}" = "gemfile" ]; then
     # if Gemfile.lock is here
-    if [[ -f 'Gemfile.lock' ]]; then
+    if [ -f 'Gemfile.lock' ]; then
       # grep for rubocop extension version
-      RUBOCOP_EXTENSION_GEMFILE_VERSION=`cat Gemfile.lock | grep -oP "^\s{4}$INPUT_RUBOCOP_EXTENSION_NAME\s\(\K.*(?=\))"`
+      RUBOCOP_EXTENSION_GEMFILE_VERSION=$(pcregrep -o "^\s{4}$INPUT_RUBOCOP_EXTENSION_NAME\s\(\K.*(?=\))" Gemfile.lock)
 
       # if rubocop extension version found, then pass it to the gem install
       # left it empty otherwise, so no version will be passed
-      if [[ -n "$RUBOCOP_EXTENSION_GEMFILE_VERSION" ]]; then
+      if [ -n "$RUBOCOP_EXTENSION_GEMFILE_VERSION" ]; then
         RUBOCOP_EXTENSION_VERSION=$RUBOCOP_EXTENSION_GEMFILE_VERSION
         else
           printf "Cannot get the rubocop extension version from Gemfile.lock. The latest version will be installed."
@@ -61,14 +61,23 @@ for extension in $INPUT_RUBOCOP_EXTENSIONS; do
     RUBOCOP_EXTENSION_VERSION=$INPUT_RUBOCOP_EXTENSION_VERSION
   fi
 
-  gem install -N $INPUT_RUBOCOP_EXTENSION_NAME $(version $RUBOCOP_EXTENSION_VERSION)
+  # Handle extensions with no version qualifier
+  if [ -z "${RUBOCOP_EXTENSION_VERSION}" ]; then
+    unset RUBOCOP_EXTENSION_VERSION_FLAG
+  else
+    RUBOCOP_EXTENSION_VERSION_FLAG="--version ${RUBOCOP_EXTENSION_VERSION}"
+  fi
+
+  # shellcheck disable=SC2086
+  gem install -N "${INPUT_RUBOCOP_EXTENSION_NAME}" ${RUBOCOP_EXTENSION_VERSION_FLAG}
 done
 
+# shellcheck disable=SC2086
 rubocop ${INPUT_RUBOCOP_FLAGS} \
   | reviewdog -f=rubocop \
       -name="${INPUT_TOOL_NAME}" \
       -reporter="${INPUT_REPORTER}" \
       -filter-mode="${INPUT_FILTER_MODE}" \
       -fail-on-error="${INPUT_FAIL_ON_ERROR}" \
       -level="${INPUT_LEVEL}" \
-      ${INPUT_REVIEWDOG_FLAGS}
+      "${INPUT_REVIEWDOG_FLAGS}"