feat: enhance VButton with outlined variant, size system and SCSS mixins - #586
Draft
timothejoubert wants to merge 9 commits into
Draft
feat: enhance VButton with outlined variant, size system and SCSS mixins#586timothejoubert wants to merge 9 commits into
timothejoubert wants to merge 9 commits into
Conversation
manuelodelain
requested changes
Jun 10, 2026
|
|
||
| // Outputs CSS property declarations using the CSS variables set by `size()`, with sm values as fallbacks. | ||
| // Usage: @include v-button.apply('') or @include v-button.apply('label') | ||
| @mixin apply($prefix: '') { |
Member
There was a problem hiding this comment.
Why moving the css props to the mixin instead of keeping it into the VButton component style?
Contributor
Author
There was a problem hiding this comment.
Like that, we can fully style a custom element with the same VButton variant style without using the VButton component
timothejoubert
marked this pull request as draft
June 23, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applymixin to css-vars-map for declaring properties with var() fallbacks_v-button-outlined.scsscomponent styles