Merge pull request #64 from rh-aiservices-bu/orphaned-key-fix

fix(test): handle orphaned keys and improve server startup

Author: guimou

backend/src/lib/database-migrations.ts

@@ -656,6 +656,7 @@ export const backfillLiteLLMKeyAlias = async (dbUtils: DatabaseUtils, liteLLMSer
     console.log(`🔄 Backfilling litellm_key_alias for ${keysToBackfill.length} API keys...`);
 
     let successCount = 0;
+    let orphanedCount = 0;
     let errorCount = 0;
 
     for (const key of keysToBackfill) {
@@ -671,15 +672,26 @@ export const backfillLiteLLMKeyAlias = async (dbUtils: DatabaseUtils, liteLLMSer
 
         successCount++;
       } catch (error) {
-        console.error(
-          `Failed to backfill key_alias for API key ${key.id}:`,
-          error instanceof Error ? error.message : error,
-        );
-        errorCount++;
+        // Handle 404s (orphaned keys) differently - mark without verbose logging
+        if (error instanceof Error && error.message?.includes('404')) {
+          await dbUtils.query(`UPDATE api_keys SET litellm_key_alias = $1 WHERE id = $2`, [
+            `orphaned_${key.id}`,
+            key.id,
+          ]);
+          orphanedCount++;
+        } else {
+          console.error(
+            `Failed to backfill key_alias for API key ${key.id}:`,
+            error instanceof Error ? error.message : error,
+          );
+          errorCount++;
+        }
       }
     }
 
-    console.log(`✅ Backfilled litellm_key_alias: ${successCount} succeeded, ${errorCount} failed`);
+    console.log(
+      `✅ Backfilled litellm_key_alias: ${successCount} succeeded, ${orphanedCount} orphaned, ${errorCount} failed`,
+    );
   } catch (error) {
     console.error('❌ Failed to backfill litellm_key_alias:', error);
     // Don't throw - this is a best-effort migration

backend/src/plugins/database.ts

@@ -36,38 +36,42 @@ const databasePlugin: FastifyPluginAsync = async (fastify) => {
           // Don't fail the startup, but log the error
         }
 
-        // Backfill litellm_key_alias for existing API keys
-        try {
-          const { backfillLiteLLMKeyAlias } = await import('../lib/database-migrations');
-          const { LiteLLMService } = await import('../services/litellm.service');
-          const liteLLMService = new LiteLLMService(fastify);
-          await backfillLiteLLMKeyAlias(fastify.dbUtils, liteLLMService);
-        } catch (backfillError) {
-          fastify.log.error(backfillError as Error, 'Failed to backfill litellm_key_alias');
-          // Don't fail the startup, but log the error
-        }
-
-        // Skip initial model sync in test environment
-        // Tests can explicitly sync models if needed for their scenarios
-        if (process.env.NODE_ENV !== 'test') {
-          // Sync models on startup
+        // Start LiteLLM-dependent operations in background - don't block server startup
+        setImmediate(async () => {
+          // Background task 1: Backfill litellm_key_alias for existing API keys
           try {
-            const { ModelSyncService } = await import('../services/model-sync.service');
-            const modelSyncService = new ModelSyncService(fastify);
-            const syncResult = await modelSyncService.syncModels({
-              forceUpdate: false,
-              markUnavailable: true,
-            });
+            fastify.log.info('Starting background backfill of litellm_key_alias');
+            const { backfillLiteLLMKeyAlias } = await import('../lib/database-migrations');
+            const { LiteLLMService } = await import('../services/litellm.service');
+            const liteLLMService = new LiteLLMService(fastify);
+            await backfillLiteLLMKeyAlias(fastify.dbUtils, liteLLMService);
+            fastify.log.info('Background backfill completed successfully');
+          } catch (backfillError) {
+            fastify.log.error(backfillError as Error, 'Background backfill failed');
+          }
+
+          // Background task 2: Sync models from LiteLLM
+          // Skip in test environment
+          if (process.env.NODE_ENV !== 'test') {
+            try {
+              fastify.log.info('Starting background model sync from LiteLLM');
+              const { ModelSyncService } = await import('../services/model-sync.service');
+              const modelSyncService = new ModelSyncService(fastify);
+              const syncResult = await modelSyncService.syncModels({
+                forceUpdate: false,
+                markUnavailable: true,
+              });
 
-            fastify.log.info({
-              msg: 'Initial model sync completed',
-              ...syncResult,
-            });
-          } catch (syncError) {
-            fastify.log.error({ error: syncError }, 'Failed to sync models on startup');
-            // Don't fail startup - continue with cached models
+              fastify.log.info({
+                msg: 'Background model sync completed',
+                ...syncResult,
+              });
+            } catch (syncError) {
+              fastify.log.error({ error: syncError }, 'Background model sync failed');
+              // Continue - services will use cached models if available
+            }
           }
-        }
+        });
 
         // Initialize LiteLLM integration service for auto-sync
         const litellmIntegrationService = new LiteLLMIntegrationService(fastify);

frontend/src/test/mocks/handlers.ts

@@ -358,6 +358,11 @@ export const handlers = [
     });
   }),
 
+  // Banner endpoint (used by BannerProvider in Layout)
+  http.get('/api/v1/banners', () => {
+    return HttpResponse.json([]);
+  }),
+
   // Error simulation endpoints
   http.get('/api/v1/test-error', () => {
     return HttpResponse.json(