NVIDIA-475,NVIDIA-473: Add ignition generator

Author: eelgaev

.golangci.yml

@@ -31,6 +31,11 @@ linters:
         - name: import-shadowing
   exclusions:
     generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
     rules:
       - linters:
           - lll

api/v1alpha1/dpfhcpprovisioner_types.go

@@ -36,6 +36,19 @@ type DPUClusterReference struct {
 	Namespace string `json:"namespace"`
 }
 
+// DPUDeploymentReference defines a cross-namespace reference to a DPUDeployment CR
+type DPUDeploymentReference struct {
+	// Name is the name of the DPUDeployment CR
+	// +kubebuilder:validation:Required
+	// +required
+	Name string `json:"name"`
+
+	// Namespace is the namespace of the DPUDeployment CR
+	// +kubebuilder:validation:Required
+	// +required
+	Namespace string `json:"namespace"`
+}
+
 // DPFHCPProvisionerSpec defines the desired state of DPFHCPProvisioner
 // +kubebuilder:validation:XValidation:rule="self.controlPlaneAvailabilityPolicy != 'HighlyAvailable' || (has(self.virtualIP) && size(self.virtualIP) > 0)",message="virtualIP is required when controlPlaneAvailabilityPolicy is HighlyAvailable"
 type DPFHCPProvisionerSpec struct {
@@ -130,10 +143,21 @@ type DPFHCPProvisionerSpec struct {
 	// +immutable
 	// +optional
 	FlannelEnabled *bool `json:"flannelEnabled,omitempty"`
+
+	// DPUDeploymentRef is a cross-namespace reference to a DPUDeployment CR for ignition generation
+	// This field is used for ignition generation to retrieve DPU flavor information
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="dpuDeploymentRef is immutable"
+	// +required
+	DPUDeploymentRef *DPUDeploymentReference `json:"dpuDeploymentRef,omitempty"`
+
+	// MachineOSURL is the URL for the DPU machine OS image to be used in the ignition configuration
+	// This URL replaces the default OS image URL in the HyperShift-generated ignition
+	// +optional
+	MachineOSURL string `json:"machineOSURL,omitempty"`
 }
 
 // DPFHCPProvisionerPhase represents the lifecycle phase of the DPFHCPProvisioner
-// +kubebuilder:validation:Enum=Pending;Provisioning;Ready;Failed;Deleting
+// +kubebuilder:validation:Enum=Pending;Provisioning;IgnitionGenerating;Ready;Failed;Deleting
 type DPFHCPProvisionerPhase string
 
 const (
@@ -143,6 +167,9 @@ const (
 	// PhaseProvisioning indicates HostedCluster and related resources are being created
 	PhaseProvisioning DPFHCPProvisionerPhase = "Provisioning"
 
+	// PhaseIgnitionGenerating indicates ignition generation is in progress
+	PhaseIgnitionGenerating DPFHCPProvisionerPhase = "IgnitionGenerating"
+
 	// PhaseReady indicates HostedCluster is operational, kubeconfig injected, CSR auto-approval active
 	PhaseReady DPFHCPProvisionerPhase = "Ready"
 
@@ -213,6 +240,9 @@ const (
 	// MetalLBConfigured indicates whether MetalLB resources (IPAddressPool and L2Advertisement)
 	// have been successfully created and are in sync with the DPFHCPProvisioner spec.
 	MetalLBConfigured string = "MetalLBConfigured"
+
+	// IgnitionConfigured indicates whether the ignition configuration has been successfully generated and deployed
+	IgnitionConfigured string = "IgnitionConfigured"
 )
 
 // Condition reasons for DPFHCPProvisioner Ready status.

api/v1alpha1/zz_generated.deepcopy.go

@@ -37,6 +37,8 @@ import (
 	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
 
+	dpuservicev1alpha1 "github.com/nvidia/doca-platform/api/dpuservice/v1alpha1"
+	operatorv1alpha1 "github.com/nvidia/doca-platform/api/operator/v1alpha1"
 	dpuprovisioningv1alpha1 "github.com/nvidia/doca-platform/api/provisioning/v1alpha1"
 	hyperv1 "github.com/openshift/hypershift/api/hypershift/v1beta1"
 	provisioningv1alpha1 "github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator/api/v1alpha1"
@@ -47,6 +49,7 @@ import (
 	"github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator/internal/controller/dpucluster"
 	"github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator/internal/controller/finalizer"
 	"github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator/internal/controller/hostedcluster"
+	"github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator/internal/controller/ignitiongenerator"
 	"github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator/internal/controller/kubeconfiginjection"
 	"github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator/internal/controller/metallb"
 	"github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator/internal/controller/secrets"
@@ -64,6 +67,8 @@ func init() {
 
 	utilruntime.Must(provisioningv1alpha1.AddToScheme(scheme))
 	utilruntime.Must(dpuprovisioningv1alpha1.AddToScheme(scheme))
+	utilruntime.Must(dpuservicev1alpha1.AddToScheme(scheme))
+	utilruntime.Must(operatorv1alpha1.AddToScheme(scheme))
 	utilruntime.Must(hyperv1.AddToScheme(scheme))
 	utilruntime.Must(metallbv1beta1.AddToScheme(scheme))
 	// +kubebuilder:scaffold:scheme
@@ -268,6 +273,9 @@ func main() {
 	// Initialize Status Syncer for HostedCluster status mirroring
 	statusSyncer := hostedcluster.NewStatusSyncer(client)
 
+	// Initialize Ignition Generator for DPF provisioning
+	ignitionGenerator := ignitiongenerator.NewIgnitionGenerator(client, scheme, provisionerRecorder)
+
 	// Setup main DPFHCPProvisioner controller
 	if err := (&controller.DPFHCPProvisionerReconciler{
 		Client:               client,
@@ -283,6 +291,7 @@ func main() {
 		FinalizerManager:     finalizerManager,
 		StatusSyncer:         statusSyncer,
 		KubeconfigInjector:   kubeconfigInjector,
+		IgnitionGenerator:    ignitionGenerator,
 	}).SetupWithManager(mgr); err != nil {
 		setupLog.Error(err, "unable to create controller", "controller", "DPFHCPProvisioner")
 		os.Exit(1)

cmd/main.go

@@ -101,6 +101,24 @@ spec:
                 x-kubernetes-validations:
                 - message: dpuClusterRef is immutable
                   rule: self == oldSelf
+              dpuDeploymentRef:
+                description: |-
+                  DPUDeploymentRef is a cross-namespace reference to a DPUDeployment CR for ignition generation
+                  This field is used for ignition generation to retrieve DPU flavor information
+                properties:
+                  name:
+                    description: Name is the name of the DPUDeployment CR
+                    type: string
+                  namespace:
+                    description: Namespace is the namespace of the DPUDeployment CR
+                    type: string
+                required:
+                - name
+                - namespace
+                type: object
+                x-kubernetes-validations:
+                - message: dpuDeploymentRef is immutable
+                  rule: self == oldSelf
               etcdStorageClass:
                 description: |-
                   EtcdStorageClass is the storage class name for etcd persistent volumes in the hosted cluster control plane
@@ -121,6 +139,11 @@ spec:
                 x-kubernetes-validations:
                 - message: flannelEnabled is immutable
                   rule: self == oldSelf
+              machineOSURL:
+                description: |-
+                  MachineOSURL is the URL for the DPU machine OS image to be used in the ignition configuration
+                  This URL replaces the default OS image URL in the HyperShift-generated ignition
+                type: string
               nodeSelector:
                 additionalProperties:
                   type: string
@@ -195,6 +218,7 @@ spec:
             required:
             - baseDomain
             - dpuClusterRef
+            - dpuDeploymentRef
             - ocpReleaseImage
             - pullSecretRef
             - sshKeySecretRef
@@ -333,6 +357,7 @@ spec:
                 enum:
                 - Pending
                 - Provisioning
+                - IgnitionGenerating
                 - Ready
                 - Failed
                 - Deleting

config/crd/bases/provisioning.dpu.hcp.io_dpfhcpprovisioners.yaml

@@ -8,10 +8,12 @@ rules:
   - ""
   resources:
   - configmaps
-  - nodes
   verbs:
+  - create
   - get
   - list
+  - patch
+  - update
   - watch
 - apiGroups:
   - ""
@@ -29,6 +31,14 @@ rules:
   - get
   - list
   - watch
+- apiGroups:
+  - ""
+  resources:
+  - nodes
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - ""
   resources:
@@ -86,6 +96,15 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - operator.dpu.nvidia.com
+  resources:
+  - dpfoperatorconfigs
+  verbs:
+  - get
+  - list
+  - patch
+  - watch
 - apiGroups:
   - provisioning.dpu.hcp.io
   resources:
@@ -125,8 +144,17 @@ rules:
 - apiGroups:
   - provisioning.dpu.nvidia.com
   resources:
+  - dpuflavors
   - dpus
   verbs:
   - get
   - list
   - watch
+- apiGroups:
+  - svc.dpu.nvidia.com
+  resources:
+  - dpudeployments
+  verbs:
+  - get
+  - list
+  - watch

config/rbac/role.yaml

@@ -3,6 +3,7 @@ module github.com/rh-ecosystem-edge/dpf-hcp-provisioner-operator
 go 1.25
 
 require (
+	github.com/coreos/ignition/v2 v2.26.0
 	github.com/nvidia/doca-platform v0.0.0-20251115082520-81369e955c6c
 	github.com/onsi/ginkgo/v2 v2.27.2
 	github.com/onsi/gomega v1.38.2
@@ -20,10 +21,14 @@ require (
 	cel.dev/expr v0.24.0 // indirect
 	github.com/Masterminds/semver/v3 v3.4.0 // indirect
 	github.com/antlr4-go/antlr/v4 v4.13.1 // indirect
+	github.com/aws/aws-sdk-go-v2 v1.41.1 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/blang/semver/v4 v4.0.0 // indirect
 	github.com/cenkalti/backoff/v5 v5.0.2 // indirect
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
+	github.com/coreos/go-semver v0.3.1 // indirect
+	github.com/coreos/go-systemd/v22 v22.6.0 // indirect
+	github.com/coreos/vcontext v0.0.0-20231102161604-685dc7299dc5 // indirect
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/emicklei/go-restful/v3 v3.12.2 // indirect
 	github.com/evanphx/json-patch/v5 v5.9.11 // indirect
@@ -52,6 +57,7 @@ require (
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
+	github.com/opencontainers/go-digest v1.0.0 // indirect
 	github.com/openshift/api v0.0.0-20251204193610-68ce3d906ec8 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
@@ -60,37 +66,38 @@ require (
 	github.com/prometheus/common v0.65.0 // indirect
 	github.com/prometheus/procfs v0.16.1 // indirect
 	github.com/spf13/cobra v1.9.1 // indirect
-	github.com/spf13/pflag v1.0.7 // indirect
+	github.com/spf13/pflag v1.0.10 // indirect
 	github.com/stoewer/go-strcase v1.3.0 // indirect
+	github.com/vincent-petithory/dataurl v1.0.0 // indirect
 	github.com/x448/float16 v0.8.4 // indirect
-	go.opentelemetry.io/auto/sdk v1.1.0 // indirect
-	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.60.0 // indirect
-	go.opentelemetry.io/otel v1.37.0 // indirect
+	go.opentelemetry.io/auto/sdk v1.2.1 // indirect
+	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.61.0 // indirect
+	go.opentelemetry.io/otel v1.38.0 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.37.0 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.37.0 // indirect
-	go.opentelemetry.io/otel/metric v1.37.0 // indirect
-	go.opentelemetry.io/otel/sdk v1.37.0 // indirect
-	go.opentelemetry.io/otel/trace v1.37.0 // indirect
+	go.opentelemetry.io/otel/metric v1.38.0 // indirect
+	go.opentelemetry.io/otel/sdk v1.38.0 // indirect
+	go.opentelemetry.io/otel/trace v1.38.0 // indirect
 	go.opentelemetry.io/proto/otlp v1.7.0 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
 	go.uber.org/zap v1.27.0 // indirect
 	go.yaml.in/yaml/v2 v2.4.2 // indirect
 	go.yaml.in/yaml/v3 v3.0.4 // indirect
 	golang.org/x/exp v0.0.0-20250305212735-054e65f0b394 // indirect
-	golang.org/x/mod v0.29.0 // indirect
-	golang.org/x/net v0.47.0 // indirect
-	golang.org/x/oauth2 v0.30.0 // indirect
-	golang.org/x/sync v0.18.0 // indirect
-	golang.org/x/sys v0.38.0 // indirect
-	golang.org/x/term v0.37.0 // indirect
-	golang.org/x/text v0.31.0 // indirect
-	golang.org/x/time v0.11.0 // indirect
-	golang.org/x/tools v0.38.0 // indirect
+	golang.org/x/mod v0.31.0 // indirect
+	golang.org/x/net v0.49.0 // indirect
+	golang.org/x/oauth2 v0.34.0 // indirect
+	golang.org/x/sync v0.19.0 // indirect
+	golang.org/x/sys v0.40.0 // indirect
+	golang.org/x/term v0.39.0 // indirect
+	golang.org/x/text v0.33.0 // indirect
+	golang.org/x/time v0.14.0 // indirect
+	golang.org/x/tools v0.40.0 // indirect
 	gomodules.xyz/jsonpatch/v2 v2.5.0 // indirect
-	google.golang.org/genproto/googleapis/api v0.0.0-20250603155806-513f23925822 // indirect
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20250603155806-513f23925822 // indirect
-	google.golang.org/grpc v1.73.0 // indirect
-	google.golang.org/protobuf v1.36.7 // indirect
+	google.golang.org/genproto/googleapis/api v0.0.0-20251202230838-ff82c1b0f217 // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20251222181119-0a764e51fe1b // indirect
+	google.golang.org/grpc v1.78.0 // indirect
+	google.golang.org/protobuf v1.36.11 // indirect
 	gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect