Switch ran eco gotests version comparison to semver CNF-20904 (#1322)

* cnf/ran: implement SemVer for RAN version gate checks

Replace ad hoc major/minor version checks with github.com/Masterminds/semver/v3.

- Add semver_range.go with IsVersionStringInRange (minimum <= v < exclusive maximum),
  including two-segment X.Y maximum as whole minor line; document 4.N.0-0 lower bounds.
- Add table-driven unit tests (document UNIT_TEST=true for local runs without kubeconfig).
- Declare github.com/Masterminds/semver/v3 in the primary go.mod require block.
- Update RAN call sites (GitOps/ZTP, TALM, PTP, power management) to use 4.N.0-0 minimums.

* cnf/ran: address PR 1322 review (semver gates)

- Reject two-segment maximum strings that include a prerelease or build suffix;
  propagate NewVersion errors when constructing the implicit upper bound.
- Move IsVersionStringInRange helpers into version.go and remove semver_range.go.
- Treat explicit multi-segment maximum as the exclusive upper bound (half-open
  interval); keep plain X.Y shorthand for the next-minor exclusive bound; update
  tests plus TALM backup and PTP event-consumer call sites.

* unify semver maximum parsing with minimum

- Add parseSemverGateBound and route minimum/maximum through the same
  trim + coerceSemverCore + NewVersion path; drop two-segment maximum shorthand.
- Document that non-empty maximum must be an explicit semver exclusive bound.
- Update version_test table maxima to explicit exclusives (e.g. 4.21.0-0 for the
  old "4.20" shorthand); remove the redundant 4.15-rc.1 error case.

Made-with: Cursor

* cnf/ptp: fix ptp-interfaces per CodeRabbit review

- Restore AssertWithTimeout to 3m alongside the 30s stable window for
  clock-state Prometheus assertions (45s was too tight for scrape + stabilize).
- Use GetProfileByDaemonName for HA profile lookups so daemon-qualified names
  (ConfigName_ProfileName) resolve.

Made-with: Cursor

* chore: satisfy golangci-lint for cnf/ran version (scoped)

- Allow github.com/Masterminds/semver/v3 in .golangci.yml depguard main list.

- Fix lll (wrap version_test package comment), nilnil nolints for empty bounds,

  varnamelen (parsedVersion, splitSemverCore param), and wsl spacing.

Made-with: Cursor

* cnf/talm: restore precache Eventually timeout to 30 minutes

Revert the precache status poll duration from 20m to 30m so this line is not altered by the RAN semver workstream. Matches maintainer feedback on #1322.

Made-with: Cursor

* cnf/ran: parse version gate bounds with semver only

Drop coerceSemverCore and related helpers; parse minimum and maximum the same way as the subject version (trimSemverVPrefix + semver.NewVersion). Call sites already pass full semver strings (e.g. X.Y.0-0). Addresses review feedback on #1322.

Made-with: Cursor

* cnf/ran: log unparsable version in IsVersionStringInRange legacy path

When maximum is empty and the subject version is not valid semver, preserve (true, nil) for legacy callers but emit klog.V(ranparam.LogLevel) diagnostics. Addresses CodeRabbit feedback on #1322.

Made-with: Cursor

Author: bazem8

.golangci.yml

@@ -64,6 +64,7 @@ linters:
             - github.com/openshift
             - github.com/nmstate/kubernetes-nmstate
             - github.com/hashicorp/go-version
+            - github.com/Masterminds/semver/v3
             - github.com/cavaliergopher/grab/v3
             - github.com/k8snetworkplumbingwg
             - github.com/metallb/metallb-operator

go.mod

@@ -7,6 +7,7 @@ toolchain go1.26.0
 require (
 	github.com/BurntSushi/toml v1.6.0
 	github.com/Juniper/go-netconf v0.3.1
+	github.com/Masterminds/semver/v3 v3.4.0
 	github.com/Masterminds/sprig/v3 v3.3.0
 	github.com/NVIDIA/gpu-operator v1.11.1
 	github.com/cavaliergopher/cpio v1.0.1
@@ -80,7 +81,6 @@ require (
 	github.com/Azure/go-ansiterm v0.0.0-20250102033503-faa5f7b0171c // indirect
 	github.com/MakeNowJust/heredoc v1.0.0 // indirect
 	github.com/Masterminds/goutils v1.1.1 // indirect
-	github.com/Masterminds/semver/v3 v3.4.0 // indirect
 	github.com/Microsoft/go-winio v0.6.2 // indirect
 	github.com/PaesslerAG/gval v1.0.0 // indirect
 	github.com/PaesslerAG/jsonpath v0.1.1 // indirect

tests/cnf/ran/gitopsztp/tests/ztp-argocd-acm-crs.go

@@ -30,7 +30,7 @@ var _ = Describe("ZTP Argo CD ACM CR Tests", Label(tsparams.LabelArgoCdAcmCrsTes
 	BeforeEach(func() {
 		By("verifying that ZTP meets the minimum version")
 
-		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.12", "")
+		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.12.0-0", "")
 		Expect(err).ToNot(HaveOccurred(), "Failed to compare ZTP version string")
 
 		if !versionInRange {

tests/cnf/ran/gitopsztp/tests/ztp-argocd-clusters-app.go

@@ -26,7 +26,7 @@ var _ = Describe("ZTP Argo CD Clusters Tests", Label(tsparams.LabelArgoCdCluster
 	BeforeEach(func() {
 		By("verifying that ZTP meets the minimum version")
 
-		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.11", "")
+		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.11.0-0", "")
 		Expect(err).ToNot(HaveOccurred(), "Failed to compare ZTP version string")
 
 		if !versionInRange {

tests/cnf/ran/gitopsztp/tests/ztp-argocd-hub-templating.go

@@ -37,7 +37,7 @@ var _ = Describe("ZTP Argo CD Hub Templating Tests", Label(tsparams.LabelArgoCdH
 	BeforeEach(func() {
 		By("checking the ZTP version")
 
-		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.12", "")
+		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.12.0-0", "")
 		Expect(err).ToNot(HaveOccurred(), "Failed to check if ZTP version is in range")
 
 		if !versionInRange {
@@ -116,7 +116,7 @@ var _ = Describe("ZTP Argo CD Hub Templating Tests", Label(tsparams.LabelArgoCdH
 		It("should create the policy successfully with a valid template", reportxml.ID("54240"), func() {
 			By("checking the ZTP version")
 
-			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.16", "")
+			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.16.0-0", "")
 			Expect(err).ToNot(HaveOccurred(), "Failed to check if ZTP version is in range")
 
 			validTestPath := tsparams.ZtpTestPathTemplatingValid

tests/cnf/ran/gitopsztp/tests/ztp-argocd-node-delete.go

@@ -31,7 +31,7 @@ var _ = Describe("ZTP Argo CD Node Deletion Tests", Label(tsparams.LabelArgoCdNo
 	BeforeEach(func() {
 		By("checking the ZTP version")
 
-		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.14", "")
+		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.14.0-0", "")
 		Expect(err).ToNot(HaveOccurred(), "Failed to check if ZTP version is in range")
 
 		if !versionInRange {

tests/cnf/ran/gitopsztp/tests/ztp-argocd-policies-app.go

@@ -35,7 +35,7 @@ var _ = Describe("ZTP Argo CD Policies Tests", Label(tsparams.LabelArgoCdPolicie
 	BeforeEach(func() {
 		By("checking the ZTP version")
 
-		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.10", "")
+		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.10.0-0", "")
 		Expect(err).ToNot(HaveOccurred(), "Failed to check if ZTP version is in range")
 
 		if !versionInRange {
@@ -315,7 +315,7 @@ var _ = Describe("ZTP Argo CD Policies Tests", Label(tsparams.LabelArgoCdPolicie
 			"the same file name", reportxml.ID("62260"), func() {
 			By("checking the ZTP version")
 
-			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.14", "")
+			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.14.0-0", "")
 			Expect(err).ToNot(HaveOccurred(), "Failed to check if ZTP version is in range")
 
 			if !versionInRange {
@@ -355,7 +355,7 @@ var _ = Describe("ZTP Argo CD Policies Tests", Label(tsparams.LabelArgoCdPolicie
 			"source-cr is used in PGT", reportxml.ID("63516"), func() {
 			By("checking the ZTP version")
 
-			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.14", "")
+			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.14.0-0", "")
 			Expect(err).ToNot(HaveOccurred(), "Failed to check if ZTP version is in range")
 
 			if !versionInRange {
@@ -388,7 +388,7 @@ var _ = Describe("ZTP Argo CD Policies Tests", Label(tsparams.LabelArgoCdPolicie
 		It("verifies custom and default source CRs can be included in the same policy", reportxml.ID("64407"), func() {
 			By("checking the ZTP version")
 
-			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.14", "")
+			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.14.0-0", "")
 			Expect(err).ToNot(HaveOccurred(), "Failed to check if ZTP version is in range")
 
 			if !versionInRange {

tests/cnf/ran/gitopsztp/tests/ztp-bios-day-zero.go

@@ -25,7 +25,7 @@ var _ = Describe("ZTP BIOS Configuration Tests", Label(tsparams.LabelBiosDayZero
 
 	// 75196 - Check if spoke has required BIOS setting values applied
 	It("Verifies SNO spoke has required BIOS setting values applied", reportxml.ID("75196"), func() {
-		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.17", "")
+		versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.17.0-0", "")
 		Expect(err).ToNot(HaveOccurred(), "Failed to check if ZTP version is in range")
 
 		if !versionInRange {

tests/cnf/ran/gitopsztp/tests/ztp-cluster-instance-delete.go

@@ -38,7 +38,7 @@ var _ = Describe("ZTP Siteconfig Operator's Cluster Instance Delete Tests",
 		BeforeEach(func() {
 			By("verifying that ZTP meets the minimum version")
 
-			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.17", "")
+			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.17.0-0", "")
 			Expect(err).ToNot(HaveOccurred(), "Failed to compare ZTP version string")
 
 			if !versionInRange {

tests/cnf/ran/gitopsztp/tests/ztp-siteconfig-day-two.go

@@ -28,7 +28,7 @@ var _ = Describe("ZTP Siteconfig Operator's Day 2 configuration Test",
 		BeforeEach(func() {
 			By("verifying that ZTP meets the minimum version")
 
-			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.17", "")
+			versionInRange, err := version.IsVersionStringInRange(RANConfig.ZTPVersion, "4.17.0-0", "")
 			Expect(err).ToNot(HaveOccurred(), "Failed to compare ZTP version string")
 
 			if !versionInRange {