ai suggested fixes

Author: maorfr

operators/openshift-pipelines-operator-rh/clair_import_pipeline.yaml

@@ -40,14 +40,20 @@
             image: "{{ oc_cli_image }}"
             script: |
                 #!/bin/bash
+                set -uo pipefail
 
                 clair_pod_name=$(oc get pods -n quay-enterprise -l quay-component=clair-app -o name | cut -d/ -f2)
-                oc exec -n quay-enterprise $clair_pod_name -- \
+                if oc exec -n quay-enterprise "$clair_pod_name" -- \
                 /bin/sh -c "
                   curl -L -o /tmp/updates.json.gz http://{{ quayHostname }}/clair/updates.json.gz
                   /usr/bin/clairctl --config /clair/config.yaml import-updaters /tmp/updates.json.gz
-                " > $(results.status-report.path)
-                echo $? > $(results.exit-code.path)
+                " > "$(results.status-report.path)" 2>&1; then
+                  rc=0
+                else
+                  rc=$?
+                fi
+                echo "$rc" > "$(results.exit-code.path)"
+                exit "$rc"
 
 - name: Create Clair Import Pipeline
   kubernetes.core.k8s:
@@ -63,9 +69,9 @@
           - name: clair-import
             taskRef:
               name: clair-import
-            results:
-              - name: exit-code
-                value: $(tasks.clair-import.results.exit-code)
-              - name: status-report
-                value: $(tasks.clair-import.results.status-report)
+        results:
+          - name: exit-code
+            value: $(tasks.clair-import.results.exit-code)
+          - name: status-report
+            value: $(tasks.clair-import.results.status-report)
         timeout: "1h"

operators/quay-operator/clair_disconnected.yaml

@@ -49,7 +49,10 @@
       rules:
         - apiGroups: [""]
           resources: ["pods"]
-          verbs: ["get", "list", "exec"]
+          verbs: ["get", "list"]
+        - apiGroups: [""]
+          resources: ["pods/exec"]
+          verbs: ["create"]
 
 - name: Create Clair Import RoleBinding
   kubernetes.core.k8s: