Weight on menu items is ignored

[asubiotto]

I believe that #480 caused a regression when sorting menu items. Here is a menu definition that used to work (Home is sorted before About):

[menu]
    [[menu.main]]
        name = "Home"
        weight = 1
        identifier = "home"
        pageRef = "/"
    [[menu.main]]
        name = "About"
        weight = 2
        identifier = "about"
        pageRef = "about/"
    [[menu.main]]
        name = "Portfolio"
        weight = 3
        identifier = "portfolio"
        pageRef = "portfolio/"

However, this menu now sorts About before Home. Modifying the identifier for Home from home to _home achieves the correct order, which makes me believe #480 is what broke this. Forgive me if I do not completely understand, but I think the @joshuamkite's use case should be handled by assigning weights to menu items rather than sorting by identifier, so I propose reverting that change. In any case, it seems like assigning weights to menu items is currently broken.

[jasondunsmore]

I encountered this as well. Solved by reverting #480

cd themes/hello-friend-ng/
git revert e78a00ee84e1635d54231fc8b37a087c05fa62d2