Skip to content

Fix prettier formatting violations on main blocking adoption-insights CI #37

Open
#73
Open
Fix prettier formatting violations on main blocking adoption-insights CI#37
#73
Labels
bugSomething isn't workingready-for-triageTriggers triage agent dispatchready-to-codeworkspace/adoption-insights

Description

@fullsend-ai-retro
fullsend-ai-retro
bot
opened on Sep 3, 2026

What happened

PR #33 (scope migration) was self-merged in 11 seconds at 16:02:50Z without review, introducing prettier formatting violations in workspaces/adoption-insights/packages/backend/src/index.ts and workspaces/adoption-insights/plugins/adoption-insights-backend/README.md. These files were modified in PR #33 but not formatted before merge.

The subsequent changeset release PR #34 was also merged before CI completed (45 seconds after creation). When CI finally ran (run 33777442732), prettier checks failed on both node 22 and node 24, confirming the violations are on main.

PR #35 (another Version Packages PR for adoption-insights) is currently open and will also fail CI for the same reason.

What could go better

The prettier formatting violations were introduced because PR #33 was self-merged in 11 seconds — before either the review agent or CI could run. The review agent would likely have caught formatting issues since it runs linting checks. The CI prettier check would have caught them too, but the PR was merged before CI completed.

This is a direct consequence of the fast-merge pattern identified in the previous retro on PR #33. There is high confidence this is the root cause: the PR #34 diff only touches version numbers and changelogs, while the failing files (index.ts and README.md) were confirmed modified in PR #33's diff.

The Node 24 CI jobs also show native module build warnings for cpu-features@0.0.10 and ssh2@1.16.0 (NAN/V8 API incompatibilities), but these appear to be non-fatal during yarn install — the actual CI step failure on both node versions is the prettier check.

Proposed change

Run yarn prettier --write on the two affected files in the adoption-insights workspace and commit the fix:

cd workspaces/adoption-insights
yarn prettier --write packages/backend/src/index.ts plugins/adoption-insights-backend/README.md

This unblocks CI for the adoption-insights workspace, including the currently open PR #35.

Validation criteria

After the fix is merged: (1) the CI prettier check passes for the adoption-insights workspace on main, (2) PR #35 (or its successor Version Packages PR) passes CI and can be merged, and (3) no new prettier violations are reported for the adoption-insights workspace.

Generated by retro agent from #34

Activity

  1. fullsend-ai-retro
    added
    ready-for-triageTriggers triage agent dispatch
    on Sep 3, 2026

  2. fullsend-ai-triage commented on Sep 3, 2026

    @fullsend-ai-triage
    fullsend-ai-triageBot
    on Sep 3, 2026 – with fullsend-ai-triage

    🤖 Finished Triage · ✅ Success · Started 4:27 PM UTC · Completed 4:31 PM UTC

    Commit: a917c60 · View workflow run →

    Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $0.71

  3. fullsend-ai-triage
    added
    bugSomething isn't working
    workspace/adoption-insights
    ready-to-code
    on Sep 3, 2026

  4. fullsend-ai-triage commented on Sep 3, 2026

    @fullsend-ai-triage
    fullsend-ai-triageBot
    on Sep 3, 2026 – with fullsend-ai-triage

    Re-triage update

    The prior triage analysis (Sep 3) remains accurate — the prettier violations in index.ts and README.md are still present on main. The coder agent ran previously and reported success, but no PR was created, so the issue is still unresolved.

    PR #35 (Version Packages for adoption-insights) remains open and blocked by these CI failures.

    Proposed test case

    cd workspaces/adoption-insights
yarn prettier --check packages/backend/src/index.ts plugins/adoption-insights-backend/README.md
# Expected: exit 0, no violations reported

    Next steps:

    • /fs-code — agent creates a PR to implement this issue
    • /fs-code <your instruction> — agent implements with your specific guidance

    Next steps:

    • /fs-code — agent creates a PR to implement this issue
    • /fs-code <your instruction> — agent implements with your specific guidance
    Previous run

    Severity: High

    This is blocking all CI for the adoption-insights workspace and preventing PR #35 (Version Packages) from merging, which stalls the next release.

    Recommended fix

    cd workspaces/adoption-insights
yarn prettier --write packages/backend/src/index.ts plugins/adoption-insights-backend/README.md

    Proposed test case

    cd workspaces/adoption-insights
yarn prettier --check packages/backend/src/index.ts plugins/adoption-insights-backend/README.md
# Should exit 0 with no violations reported

    Once merged, PR #35 (or its successor Version Packages PR) should pass CI and unblock the adoption-insights release.

    Labels: This is a bug (broken CI) scoped to the adoption-insights workspace.

    Next steps:

    • /fs-code — agent creates a PR to implement this issue
    • /fs-code <your instruction> — agent implements with your specific guidance

  5. fullsend-ai-coder commented on Sep 3, 2026

    @fullsend-ai-coder
    fullsend-ai-coderBot
    on Sep 3, 2026 – with fullsend-ai-coder

    🤖 Finished Code · ✅ Success · Started 4:32 PM UTC · Completed 4:38 PM UTC

    Commit: a917c60 · View workflow run →

    Runtime: claude · Model: claude-opus-4-6 · Cost: $0.61

  6. gabemontero commented on Oct 16, 2026

    @gabemontero
    gabemontero
    on Oct 16, 2026

    /fs-triage

  7. fullsend-ai-triage commented on Oct 16, 2026

    @fullsend-ai-triage
    fullsend-ai-triageBot
    on Oct 16, 2026 – with fullsend-ai-triage

    🤖 Finished Triage · ✅ Success · Started 3:19 PM UTC · Completed 3:23 PM UTC

    Commit: 7893444 · View workflow run →

    Runtime: claude · Model: claude-opus-4-6 · Effort: high · Cost: $0.77

  8. fullsend-ai-triage
    added
    ready-to-code
    and removed
    ready-to-code
    on Oct 16, 2026

  9. gabemontero commented on Oct 16, 2026

    @gabemontero
    gabemontero
    on Oct 16, 2026

    /fs-code

  10. fullsend-ai-coder commented on Oct 16, 2026

    @fullsend-ai-coder
    fullsend-ai-coderBot
    on Oct 16, 2026 – with fullsend-ai-coder

    🤖 Finished Code · ✅ Success · Started 3:25 PM UTC · Completed 3:36 PM UTC

    Commit: 7893444 · View workflow run →

    Runtime: claude · Model: claude-opus-4-6 · Effort: high · Cost: $1.75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingready-for-triageTriggers triage agent dispatchready-to-codeworkspace/adoption-insights

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions