ci: use GitHub API for functional test authorization#409
Open
alexxa wants to merge 1 commit intorhel-lightspeed:mainfrom
Open
ci: use GitHub API for functional test authorization#409alexxa wants to merge 1 commit intorhel-lightspeed:mainfrom
alexxa wants to merge 1 commit intorhel-lightspeed:mainfrom
Conversation
Replace the brittle author_association check with an API call to check effective repository permissions (admin, write, maintain). This correctly authorizes organization members even if their membership visibility is private. Also fail the job explicitly when unauthorized.
|
For team members: test commit |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the brittle author_association check with an API call to check effective repository permissions (admin, write, maintain). This correctly authorizes organization members even if their membership visibility is private. Also fail the job explicitly when unauthorized.