Skip to content

Commit 9c1b2e0

Browse files
author
Ronald Hötschl
committed
ci: verify the CLI-only package installs and ships no GUI binary
install.sh checks gpgui-helper --version unconditionally and its GPGUI_INSTALLED knob doesn't cover the helper, so it cannot validate a BUILD_GUI_HELPER=0 package. Assert the variant's actual contract instead: the three CLI binaries run, and neither GUI binary shipped.
1 parent a4285c4 commit 9c1b2e0

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

.github/workflows/build.yaml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,30 @@ jobs:
222222
-e BUILD_WEBVIEW_AUTH=0 \
223223
-v $(pwd)/build-gp-cli-${{ matrix.package }}:/workspace \
224224
yuezk/gpdev:${{ matrix.package }}-builder-tauri2
225+
# Not `bash install.sh`: that script checks `gpgui-helper --version`
226+
# unconditionally, and BUILD_GUI_HELPER=0 means it isn't built. Its
227+
# GPGUI_INSTALLED knob covers gpgui but not the helper. Rather than ask for
228+
# a new knob in the builder image, this asserts the property that actually
229+
# matters for the variant — the CLI binaries work and no GUI binary shipped.
230+
- name: Verify CLI-only ${{ matrix.package }} package in Docker
231+
run: |
232+
docker run --rm \
233+
-e COREPACK_INTEGRITY_KEYS=0 \
234+
-v $(pwd)/build-gp-cli-${{ matrix.package }}:/workspace \
235+
--entrypoint /bin/bash \
236+
yuezk/gpdev:${{ matrix.package }}-builder-tauri2 -lc '
237+
set -eux
238+
if command -v apk >/dev/null; then
239+
sudo apk add --allow-untrusted /workspace/artifacts/*.apk
240+
else
241+
sudo apt-get install -y /workspace/artifacts/*.deb
242+
fi
243+
gpclient --version
244+
gpservice --version
245+
gpauth --version
246+
! command -v gpgui-helper
247+
! command -v gpgui
248+
'
225249
- name: Upload CLI-only ${{ matrix.package }} package
226250
uses: actions/upload-artifact@v7
227251
with:

0 commit comments

Comments
 (0)