Commit 8902acb
committed
refactor: address review — helper-built paths and a fuller grep hint
Three of the five review comments were correct:
- `provider_initializer.dart` built festival-root paths by interpolating
`'/${provider.currentFestival.id}'` directly. AGENTS.md requires the typed
helpers, so both sites now go through `buildFestivalHome()`. Output is
identical; the helper adds a non-empty assert.
- The `analyze` grep hint still suggested `error\|warning`, which now hides
the info-severity findings that fail the task. Widened to
`grep -nE 'info|warning|error'`.
This means the moved widgets are no longer byte-identical to the originals
as claimed in the PR description; the two `router.go` call sites are the
only difference.
The other two comments claimed `'key': ?value` is invalid Dart. It is a
null-aware map entry, stable since 3.9 (this package requires >=3.10.0), and
is what the now-fatal `use_null_aware_elements` lint asked for — reverting
would fail `analyze`. Refuted on the threads.
Refs #524, #5271 parent 75f376d commit 8902acb
2 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
| 137 | + | |
| 138 | + | |
138 | 139 | | |
139 | 140 | | |
140 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
0 commit comments