fix: address Copilot review comments on PR #259

- Add set -o pipefail + exit code capture to test and analyze tasks so
  pipe through tee doesn't mask flutter test/analyze exit codes
- Fix StorageService docs: there is no StorageService class; the actual
  classes are FavoritesService, RatingsService, FestivalStorageService
- Add prefer_const_declarations to linter rules list (was missing)
- Reword list as "among others" to avoid implying exhaustiveness
- Fix copilot-instructions.md accessibility reference: CLAUDE.md →
  AGENTS.md (CLAUDE.md is now just an @AGENTS.md import)

https://claude.ai/code/session_015rZFtTwYwLn5Z8zQrk4sgM

Author: claude

.github/copilot-instructions.md

@@ -144,7 +144,7 @@ Full reference: [`docs/code/api/`](../docs/code/api/)
 
 ### Accessibility
 
-Every interactive element needs a `Semantics` wrapper with a `label`. See [`docs/code/accessibility.md`](../docs/code/accessibility.md) and `CLAUDE.md` for full requirements and examples.
+Every interactive element needs a `Semantics` wrapper with a `label`. See [`docs/code/accessibility.md`](../docs/code/accessibility.md) and [`AGENTS.md`](../AGENTS.md) for full requirements and examples.
 
 ### Error Handling
 

AGENTS.md

@@ -43,7 +43,7 @@ The app uses a layered architecture:
 **Infrastructure** (`lib/services/`):
 - `BeerApiService` — HTTP API calls
 - `FestivalService` — festival metadata
-- `StorageService` — SharedPreferences; contains `FavoritesService`, `RatingsService`, `FestivalStorageService`
+- `FavoritesService`, `RatingsService`, `FestivalStorageService` — SharedPreferences (all in `storage_service.dart`)
 - `TastingLogService` — tasting log persistence
 - `EnvironmentService` — environment/config detection
 - `AnalyticsService` — Firebase Analytics/Crashlytics
@@ -150,7 +150,7 @@ Container(
 )
 ```
 
-**Linter rules enforced**: `prefer_const_constructors`, `prefer_final_locals`, `prefer_final_fields`, `avoid_print`, `prefer_single_quotes`, `sort_child_properties_last`, `use_key_in_widget_constructors`.
+**Linter rules enforced** (among others): `prefer_const_constructors`, `prefer_const_declarations`, `prefer_final_locals`, `prefer_final_fields`, `avoid_print`, `prefer_single_quotes`, `sort_child_properties_last`, `use_key_in_widget_constructors`.
 
 ---
 

mise.toml

@@ -31,11 +31,13 @@ outputs = ['test/**/*.mocks.dart']
 description = "Run all Flutter tests (output saved to $TEST_LOG, or set TEST_LOG to reuse a path)"
 depends = ['generate']
 run = '''
+set -o pipefail
 TEST_LOG="${TEST_LOG:-$(mktemp /tmp/test-XXXXXX.log)}"
 echo "TEST_LOG=$TEST_LOG"
-flutter test 2>&1 | tee "$TEST_LOG"
+flutter test 2>&1 | tee "$TEST_LOG"; EXIT_CODE=$?
 echo "---"
 echo "Grep with: grep -n 'FAILED\|ERROR' $TEST_LOG"
+exit $EXIT_CODE
 '''
 
 [tasks.check]
@@ -62,11 +64,13 @@ echo "To view HTML report, install lcov and run: genhtml coverage/lcov.info -o c
 description = "Run Flutter code analysis (output saved to $ANALYZE_LOG, or set ANALYZE_LOG to reuse a path)"
 depends = ['generate']
 run = '''
+set -o pipefail
 ANALYZE_LOG="${ANALYZE_LOG:-$(mktemp /tmp/analyze-XXXXXX.log)}"
 echo "ANALYZE_LOG=$ANALYZE_LOG"
-flutter analyze --no-fatal-infos 2>&1 | tee "$ANALYZE_LOG"
+flutter analyze --no-fatal-infos 2>&1 | tee "$ANALYZE_LOG"; EXIT_CODE=$?
 echo "---"
 echo "Grep with: grep -n 'error\|warning' $ANALYZE_LOG"
+exit $EXIT_CODE
 '''
 
 [tasks."validate:festivals"]